feat(118n): make LanguageMenu reachable from the header - #316
Conversation
|
Thanks for the pull request, @dcoa! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
LanguangeMenu reacheable from header …anguageMenuCollapsible
|
🎉 This PR is included in version 2.0.0-alpha.14 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description
Moves the language selector into the header and presents it as a globe, per openedx/public-engineering#558 design.
LanguageMenuonly lived in the footer, which is off screen on course units and Studio editing views. It now also sits in the header at every viewport, using one component shared by all placements.It closes #284
Changes
Header placement
LanguageMenumoves fromshell/footer/toshell/menus/and is registered inheader.desktopRight.v1andheader.mobileRight.v1, after the user/anonymous menu. It stays in the footer.Globe presentation
mdand up, and the globe alone below. aria-label is"Change language: {language}"at every width.Mobile menu (below sm)
LanguageMenuCollapsible) is prepended toheader.mobileMenuLinks.v1, so it's at the top of the hamburger menu.MenuItemsin aMenu, separated by dividers, with the selected language in the primary color and marked aria-current.useLanguageSelectionholds the switching logic (list, pending state, optimistic switch, error toast) shared by the dropdown and the collapsible.Header styling, to match the design reference
Fixes found along the way
index.htmlhad aviewportmeta tag, so the mobile header never rendered on phones or under device emulation.FocusOnnow hasscrollLock={false}. The lock'sbody[data-scroll-locked]margin collapsed the page when the menu opened. The menu content is also wrapped in the header's Container so it lines up with the bar.Docs
docs/how_tos/i18n.rstlists the four widgets and shows how to REMOVE/REPLACE them.Testing
LanguageMenuandLanguageMenuCollapsible, covering switching, the pending label, collapsed-by-default, and the error toast.test-site/src/i18n/messages/{ar,es-419,pt_BR}.json). you can use AI for help.Screencast.from.2026-09-18.13-33-46.webm
Log in user:
Additional information
Supported by Claude