feat(form): add password, hint, placeholder, and switch field types - #284
Open
philtk79 wants to merge 3 commits into
Open
feat(form): add password, hint, placeholder, and switch field types#284philtk79 wants to merge 3 commits into
philtk79 wants to merge 3 commits into
Conversation
Extend DeclarativeForm with inputType Password/Switch, optional hints and placeholders, and writeOnly metadata for host-side secret handling.
Document new field types, align switch fieldChange with text inputs, add switch error display, expand tests and Storybook stories, and note that Storybook requires a local public/ directory. Co-authored-by: Cursor <cursoragent@cursor.com>
State that public/ must be created locally without spelling out the mkdir command. Co-authored-by: Cursor <cursoragent@cursor.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Password,Switch,hint,placeholder, andwriteOnlysupport toDeclarativeFormfor richer create/edit flows (e.g. OIDC secrets, boolean toggles, help text).fieldChangesemantics with text/select inputs, render switch validation errors below the control, and deduplicate hint markup.docs/declarative-form.mdanddocs/test-ids.md, expand Storybook stories, and add interaction/coercion tests (746 passing).Test plan
npm test— 746 tests passingmkdir public && npm run storybook→ Declarative UI / DeclarativeForm →AllFieldTypes,WithPassword,WithSwitch,WithHintwriteOnlyis passed through as host metadata (no form-side enforcement)Made with Cursor