Skip to content

SRVKP-13328: css fix for pipeline run log nav item and pipeline builder - #1290

Open
anwesha-palit-redhat wants to merge 1 commit into
openshift-pipelines:masterfrom
anwesha-palit-redhat:fix/SRVKP-13328
Open

SRVKP-13328: css fix for pipeline run log nav item and pipeline builder#1290
anwesha-palit-redhat wants to merge 1 commit into
openshift-pipelines:masterfrom
anwesha-palit-redhat:fix/SRVKP-13328

Conversation

@anwesha-palit-redhat

Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • New feature
  • Refactoring
  • Migration
  • CVE Fix

Summary

The PR includes minor CSS fixes for:

  • The Pipeline Builder modal’s empty state
  • Quick Search details label alignment for Artifact Hub tasks
  • PipelineRun log navigation items with longer names

Before Screen Recordings / Screenshot

  • The Pipeline Builder modal’s empty state
image (15)
  • Quick Search details label alignment for Artifact Hub tasks
Screenshot 2026-08-17 at 18 02 19

After Screen Recordings / Screenshot

  • The Pipeline Builder modal’s empty state
CSS-fix-2.mov
  • Quick Search details label alignment for Artifact Hub tasks
CSS-fix-2.mov
  • PipelineRun log navigation items with longer names
CSS-fix-3.mov

@openshift-ci-robot

openshift-ci-robot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

@anwesha-palit-redhat: This pull request references SRVKP-13328 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.1.0." or "openshift-5.1.0.", but it targets "Pipelines 1.25.0" instead.

Details

In response to this:

Type of Change

  • Bug fix
  • New feature
  • Refactoring
  • Migration
  • CVE Fix

Summary

The PR includes minor CSS fixes for:

  • The Pipeline Builder modal’s empty state
  • Quick Search details label alignment for Artifact Hub tasks
  • PipelineRun log navigation items with longer names

Before Screen Recordings / Screenshot

  • The Pipeline Builder modal’s empty state
image (15)
  • Quick Search details label alignment for Artifact Hub tasks
Screenshot 2026-08-17 at 18 02 19

After Screen Recordings / Screenshot

  • The Pipeline Builder modal’s empty state
CSS-fix-2.mov
  • Quick Search details label alignment for Artifact Hub tasks
CSS-fix-2.mov
  • PipelineRun log navigation items with longer names
CSS-fix-3.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anwesha-palit-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anwesha-palit-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
openshift-ci Bot requested a review from ankrsinha August 20, 2026 07:49
@openshift-ci openshift-ci Bot added the approved Label for Approved PRs label Aug 20, 2026
@qodo-code-review

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Warning

/review is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Missing Heading

The empty state no longer supplies titleText; instead, its title is rendered inside EmptyStateBody. Validate that this does not remove the expected semantic heading and accessible empty-state title.

<EmptyState headingLevel="h5" icon={SearchIcon}>
  <EmptyStateBody>
    {t('No results found')}
    <br />
    {t('Please try a different search term.')}
  </EmptyStateBody>
Layout Regression

The empty-state Bullseye is now a direct child of Stack rather than an isFilled StackItem. Confirm that it receives the remaining modal height and centers the empty state vertically across supported viewport sizes.

{showEmpty ? (
  <Bullseye>
    <EmptyState headingLevel="h5" icon={SearchIcon}>
      <EmptyStateBody>
        {t('No results found')}
        <br />
        {t('Please try a different search term.')}
      </EmptyStateBody>
    </EmptyState>
  </Bullseye>
) : (
  <StackItem isFilled>

@anwesha-palit-redhat anwesha-palit-redhat removed the approved Label for Approved PRs label Aug 20, 2026
@openshift-ci openshift-ci Bot added the approved Label for Approved PRs label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants