Skip to content

SRVKP-13294: added icon for pipelinerun column in pipeline list page - #1291

Open
anwesha-palit-redhat wants to merge 1 commit into
openshift-pipelines:masterfrom
anwesha-palit-redhat:feat/SRVKP-13294
Open

SRVKP-13294: added icon for pipelinerun column in pipeline list page#1291
anwesha-palit-redhat wants to merge 1 commit into
openshift-pipelines:masterfrom
anwesha-palit-redhat:feat/SRVKP-13294

Conversation

@anwesha-palit-redhat

Copy link
Copy Markdown
Contributor

Type of Change

  • Bug fix
  • New feature
  • Refactoring
  • Migration
  • CVE Fix

Summary

Added icon in the pipelinerun column in the pipeline list page for pipeline in pipelines

Screen Recordings / Screenshot

pipelineinpipelinerun-screen-recording.mov

@openshift-ci-robot

openshift-ci-robot commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

@anwesha-palit-redhat: This pull request references SRVKP-13294 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "5.1.0." or "openshift-5.1.0.", but it targets "Pipelines 1.25.0" instead.

Details

In response to this:

Type of Change

  • Bug fix
  • New feature
  • Refactoring
  • Migration
  • CVE Fix

Summary

Added icon in the pipelinerun column in the pipeline list page for pipeline in pipelines

Screen Recordings / Screenshot

pipelineinpipelinerun-screen-recording.mov

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anwesha-palit-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [anwesha-palit-redhat]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Label for Approved PRs label Aug 20, 2026
@anwesha-palit-redhat
anwesha-palit-redhat removed the request for review from vdemeester August 20, 2026 08:52
@anwesha-palit-redhat anwesha-palit-redhat removed the approved Label for Approved PRs label Aug 20, 2026
@qodo-code-review

Copy link
Copy Markdown

PR Reviewer Guide 🔍

Warning

/review is deprecated. Use /agentic_review instead (removal date not yet scheduled).

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 1 🔵⚪⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Empty Suffix

nameSuffix is always passed a fragment, even when the run is not a pipeline-in-pipeline run. If ResourceLink applies spacing or markup whenever this prop is present, ordinary runs may receive an empty suffix container or unwanted spacing. Pass the suffix conditionally instead.

nameSuffix={
  <>
    {isPipelineInPipelineRun(obj.latestRun) ? (
      <Tooltip content={t('Pipeline in Pipeline Run')}>
        <PipelineInPipelineIcon className="opp-pipeline-run-list__results-indicator" />
      </Tooltip>
    ) : null}
  </>
}

@qodo-code-review qodo-code-review Bot added the enhancement New feature or request label Aug 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants