OCPBUGS-112330: Fix 'supercede' typos in machineconfiguration types - #2996
OCPBUGS-112330: Fix 'supercede' typos in machineconfiguration types#2996Pratik-Redhat-Tech wants to merge 1 commit into
Conversation
Correcting grammatical spelling of 'supercede' to 'supersede' in docstrings and generated swagger documentation. Signed-off-by: Pratik Langde <plangde@redhat.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: LGTM mode |
|
@Pratik-Redhat-Tech: This pull request references Jira Issue OCPBUGS-112330, which is invalid:
Comment The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughCorrected the spelling of “supersede” in reboot precedence comments for node disruption policy file, unit, and SSH key specification and status types. No functional behavior or public declarations changed. Merge Risk: ⚪ Minimal · up to This change only corrects documentation spelling in machineconfiguration types and does not alter runtime behavior; no actionable merge-blocking risk remains after normal checks and review. 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 golangci-lint (2.12.2)Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Hello @Pratik-Redhat-Tech! Some important instructions when contributing to openshift/api: |
|
Hi @Pratik-Redhat-Tech. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This is fine, but you need to run the generators to get everything up to date, try |
|
/ok-to-test |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: everettraven The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Pipeline controller notification No second-stage tests were triggered for this PR. This can happen when:
Use |
|
@Pratik-Redhat-Tech: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Fixes OCPBUGS-112330
Correcting the grammatical spelling of 'supercede' to 'supersede' across docstrings and generated swagger documentation in machineconfiguration types.
Signed-off-by: Pratik Langde plangde@redhat.com