OCPBUGS-105402: Remove EVPN feature gate

[dasanind]

chore: OCPBUGS-105402: Remove EVPN feature gate

The EVPN feature gate has been enabled by default and is no longer needed within the product. All clusters now have EVPN functionality available without requiring an explicit feature gate.
This commit removes:

• FeatureGateEVPN definition from features/features.go
• EVPN references from all payload manifest files
• EVPN entry from features.md documentation

The feature gate graduation is complete and the gate is no longer required for cluster configuration.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@dasanind: This pull request references Jira Issue OCPBUGS-105402, which is invalid:

• expected the bug to target the "5.1.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

chore: OCPBUGS-105402: Remove EVPN feature gate

The EVPN feature gate has been enabled by default and is no longer needed within the product. All clusters now have EVPN functionality available without requiring an explicit feature gate.
This commit removes:

• FeatureGateEVPN definition from features/features.go
• EVPN references from all payload manifest files
• EVPN entry from features.md documentation

The feature gate graduation is complete and the gate is no longer required for cluster configuration.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hello @dasanind! Some important instructions when contributing to openshift/api:
API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 11afaf41-3ce1-4f6e-bce9-69f833a55bd8

📥 Commits

Reviewing files that changed from the base of the PR and between 9348b83 and 929adca.

📒 Files selected for processing (10)

• features.md
• features/features.go
• payload-manifests/featuregates/featureGate-4-10-Hypershift-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-Hypershift-TechPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-Default.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-DevPreviewNoUpgrade.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-OKD.yaml
• payload-manifests/featuregates/featureGate-4-10-SelfManagedHA-TechPreviewNoUpgrade.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.

---

📝 Walkthrough

Walkthrough

The apps/v1 and build/v1 protobuf definitions now include gogoproto package options and field annotations. The annotations control generated names, nullability, casts, marshaling, sizing, unmarshaling, getters, and stringer behavior. Protobuf field numbers and wire types remain unchanged. The EVPN feature entries and the FeatureGateVSphereMultiDisk registration were removed. The AWS ingress controller load balancer security groups registration was added.

Suggested reviewers: everettraven, sayan-biswas, vr4manta

Merge Risk: ⚪ Minimal · up to 929ad

This PR removes the no-longer-needed EVPN feature gate and its manifest and documentation references; no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely states the primary change: removing the EVPN feature gate.
Description check	✅ Passed	The description explains why the EVPN feature gate is removed and identifies the affected code, manifests, and documentation.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR diff changes only protobufs, feature-gate source/docs, and YAML manifests; it adds no test files or Ginkgo It, Describe, Context, or When declarations.
Test Structure And Quality	✅ Passed	The PR diff against its merge base changes only two .proto files, feature registration, and feature-gate manifests; it adds no Ginkgo tests or It/Eventually code to review.
Microshift Test Compatibility	✅ Passed	The PR changes only protobuf annotations, feature-gate code, documentation, and manifests; it adds no Ginkgo tests or test bodies that could use unavailable MicroShift APIs.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The PR diff against its master parent changes only two protobuf files, feature documentation, code, and manifests; it adds no Ginkgo e2e tests or test declarations.
Topology-Aware Scheduling Compatibility	✅ Passed	The PR delta changes only protobuf annotations, EVPN registration/docs, and FeatureGate manifests; it adds no workload manifests or topology, affinity, replica, selector, toleration, or PDB constra...
Ote Binary Stdout Contract	✅ Passed	The PR diff changes only protobuf annotations, feature registration/docs, and YAML manifests; it adds no OTE process-level code or stdout/logging writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The PR changes only protobuf, feature documentation/code, and YAML manifests; it adds no Ginkgo e2e tests or test connectivity code requiring IPv4 or public internet.
No-Weak-Crypto	✅ Passed	The PR-relative diff contains only protobuf gogoproto metadata, feature-gate removals, and YAML edits; scans found no added weak-crypto identifiers, crypto APIs, or secret comparisons.
Container-Privileges	✅ Passed	The authored PR changes only protobuf annotations, feature metadata, and EVPN list entries; its added lines contain no privileged, host*, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The PR adds no logging calls or sensitive values. It only adds protobuf annotations and removes EVPN; affected generated String methods are unchanged from the base revision.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

Warning

Some tools did not complete. Review the errors below.

🔧 golangci-lint (2.12.2)

Error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented
The command is terminated due to an error: build linters: unable to load custom analyzer "kubeapilinter": tools/_output/bin/kube-api-linter.so, plugin: not implemented

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[dasanind]

/jira refresh

[openshift-ci-robot]

@dasanind: This pull request references Jira Issue OCPBUGS-105402, which is invalid:

• expected the bug to target either version "5.1.0." or "openshift-5.1.0.", but it targets "5.0.0" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[everettraven]

/pipeline auto

[openshift-merge-bot]

Pipeline controller notification

The pipeline-auto label has been added to this PR. Second-stage tests will be triggered automatically when all first-stage tests pass.

[dasanind]

/jira refresh

[openshift-ci-robot]

@dasanind: This pull request references Jira Issue OCPBUGS-105402, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.1.0) matches configured target version for branch (5.1.0)
• bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (core-networking-bot@redhat.com), skipping review request.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dasanind]

/retest

[dasanind]

/test verify

[openshift-ci]

@dasanind: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/verify	929adca	link	true	/test verify

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.