docs: Update managed-scripts testing method - #986
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #986 +/- ##
==========================================
- Coverage 56.16% 56.13% -0.03%
==========================================
Files 83 83
Lines 6677 6677
==========================================
- Hits 3750 3748 -2
- Misses 2459 2460 +1
- Partials 468 469 +1 🚀 New features to boost your workflow:
|
|
|
||
| ```bash | ||
| # 1. Log in to a non-production cluster with cluster-admin access | ||
| oc login <cluster-api-url> |
There was a problem hiding this comment.
Just to clarify the prerequisite here: as we don't use backplane to login but cluster-admin instead.
This cluster-admin access is cluster-specific, right? So this workflow assumes the script author has a non-prod cluster they own/control and can obtain direct cluster-admin credentials rather than picking an random staging fleet cluster as with the old test-script endpoint.
If that's the intended workflow, maybe worth making that explicit in the doc?
There was a problem hiding this comment.
That's a good point. Yeah, that's intended and it is a safe method for testing scripts.
Let me mention this explicitly in the doc.
There was a problem hiding this comment.
Add a new commit with a Prerequisite to mention this.
There was a problem hiding this comment.
one more thought, does this intentionally require every script contributor to have their own non-prod cluster with direct cluster-admin access?
For SRE users who already have Backplane access, backplane login + elevate should also work with the rendered YAML, and lets them test on any suitable staging cluster without having to create/own one.
The render command itself is independent of how the kubeconfig is obtained
There was a problem hiding this comment.
Yeah, I think as long as the user have cluster-admin access, either backplane elevation or IDP cluster-admin.
Usually MCS or SRE can create their own cluster with cluster-admin, that's the cleanest way for testing. But sometime they can just borrow a cluster with backplane elevation on staging to test, that will be audited.
I pushed a new commit to make the prerequisite more clear about this. PTAL.
|
@feichashao: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: feichashao, xiaoyu74 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
What type of PR is this?
What this PR does / Why we need it?
Update docs for the changes in #980
Which Jira/Github issue(s) does this PR fix?
Related to ROSAENG-61274
Special notes for your reviewer
Unit Test Coverage
Guidelines
Test coverage checks
Pre-checks (if applicable)
/label tide/merge-method-squash