Skip to content

CM-830: Add TrustManager API types for trust-manager operand - #491

Open
openshift-app-platform-shift[bot] wants to merge 1 commit into
cert-manager-1.18from
feature/api-types-1914-1788197014
Open

CM-830: Add TrustManager API types for trust-manager operand#491
openshift-app-platform-shift[bot] wants to merge 1 commit into
cert-manager-1.18from
feature/api-types-1914-1788197014

Conversation

@openshift-app-platform-shift

Copy link
Copy Markdown

Summary

  • Introduces trustmanagers.operator.openshift.io/v1alpha1 CRD for managing trust-manager as an operand of cert-manager-operator
  • TrustManager is a cluster-scoped singleton CR (name must be cluster) that configures trust-manager deployment in the cert-manager namespace
  • Adds TrustManager FeatureGate (Alpha, default disabled) for TechPreview gating
  • Includes generated CRD manifests, deepcopy, clientset, listers, informers, integration test suite, and unit tests

API Fields

  • trustManagerConfig: logLevel, logFormat, trustNamespace (immutable), filterExpiredCertificates, defaultCAPackage, secretTargets, resources, affinity, tolerations, nodeSelector
  • secretTargets: policy-based config (Disabled/Custom) with authorizedSecrets list and CEL cross-field validation
  • defaultCAPackage: policy (Enabled/Disabled) for OpenShift trusted CA bundle integration
  • controllerConfig: labels and annotations for created resources

Test plan

  • Unit test: TrustManager CRD status has no default value
  • Integration test suite: 30 test cases covering create, update, validation, singleton, immutability, and enum validation
  • go build ./api/... passes
  • go test ./api/... passes
  • make generate && make manifests completes successfully

Enhancement Proposal

openshift/enhancements#1914

🤖 Generated with Claude Code

Introduces the trustmanagers.operator.openshift.io/v1alpha1 CRD for managing
trust-manager as an operand of cert-manager-operator. The TrustManager CR is a
cluster-scoped singleton (name must be 'cluster') that configures trust-manager
deployment in the cert-manager namespace.

Key API features:
- TrustManagerConfig: logLevel, logFormat, trustNamespace (immutable),
  filterExpiredCertificates, defaultCAPackage, secretTargets, scheduling
- SecretTargetsConfig: policy-based (Disabled/Custom) with authorizedSecrets
- DefaultCAPackageConfig: OpenShift trusted CA bundle integration
- TrustManager FeatureGate registered as Alpha (default: disabled)

Includes CRD manifests, deepcopy, generated clientset/listers/informers,
integration test suite, and unit tests.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 31, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 31, 2026

Copy link
Copy Markdown

@openshift-app-platform-shift[bot]: This pull request references CM-830 which is a valid jira issue.

Details

In response to this:

Summary

  • Introduces trustmanagers.operator.openshift.io/v1alpha1 CRD for managing trust-manager as an operand of cert-manager-operator
  • TrustManager is a cluster-scoped singleton CR (name must be cluster) that configures trust-manager deployment in the cert-manager namespace
  • Adds TrustManager FeatureGate (Alpha, default disabled) for TechPreview gating
  • Includes generated CRD manifests, deepcopy, clientset, listers, informers, integration test suite, and unit tests

API Fields

  • trustManagerConfig: logLevel, logFormat, trustNamespace (immutable), filterExpiredCertificates, defaultCAPackage, secretTargets, resources, affinity, tolerations, nodeSelector
  • secretTargets: policy-based config (Disabled/Custom) with authorizedSecrets list and CEL cross-field validation
  • defaultCAPackage: policy (Enabled/Disabled) for OpenShift trusted CA bundle integration
  • controllerConfig: labels and annotations for created resources

Test plan

  • Unit test: TrustManager CRD status has no default value
  • Integration test suite: 30 test cases covering create, update, validation, singleton, immutability, and enum validation
  • go build ./api/... passes
  • go test ./api/... passes
  • make generate && make manifests completes successfully

Enhancement Proposal

openshift/enhancements#1914

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-app-platform-shift[bot]
Once this PR has been reviewed and has the lgtm label, please assign mytreya-rh for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 31, 2026
@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Hi @openshift-app-platform-shift[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant