NO-JIRA: Updated cluster update advisor skill directory references

[jrangelramos]

Update references for the Cluster Update Advisor skill directory on agenticrun controller from /skills/cluster-update/update-advisor to /skills/cluster-update/cluster-update-advisor in order to match the current skill folder location on agentic-skills, just updated by openshift/agentic-skills#47

Summary by CodeRabbit

• Bug Fixes
  • Updated the upgrade advisor skill reference to use the correct cluster-update-advisor path.
  • Improved consistency in upgrade guidance shown to users.

[openshift-ci-robot]

@jrangelramos: This pull request explicitly references no jira issue.

Details

In response to this:

Update references for the Cluster Update Advisor skill directory on agenticrun controller from /skills/cluster-update/update-advisor to /skills/cluster-update/cluster-update-advisor in order to match the current skill folder location on agentic-skills, just updated by openshift/agentic-skills#47

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 3f51a5de-5933-4190-8502-a0e26025a756

📥 Commits

Reviewing files that changed from the base of the PR and between f94dc81 and 0db032d.

📒 Files selected for processing (2)

• pkg/agenticrun/controller.go
• pkg/agenticrun/controller_test.go

Included review availability: Your plan includes up to 1 review per rolling hour; 0 remain after this review.

---

Walkthrough

The AgenticRun controller now references cluster-update-advisor in its prompt and tool configuration. Controller tests now expect the renamed skill path.

Changes

AgenticRun skill path

Layer / File(s)	Summary
Update AgenticRun skill references pkg/agenticrun/controller.go, pkg/agenticrun/controller_test.go	The controller prompt and tool configuration use cluster-update-advisor. Tests update expected paths for all covered update scenarios.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 0db03

This localized update aligns the cluster update advisor directory references with the current skill folder location, and no actionable merge-blocking risk remains beyond normal checks and review.

Possibly related PRs

• openshift/cluster-version-operator#1446: Makes the same AgenticRun skill path updates.

Suggested labels: jira/invalid-bug

Suggested reviewers: jhadvig, racheljpg, wking

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes the updated Cluster Update Advisor skill directory references.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR changes only prompt and skill-path string literals. It adds no Ginkgo declarations or test titles; controller tests use standard testing.T and unchanged subtest names.
Test Structure And Quality	✅ Passed	The changed test file uses standard Go testing, not Ginkgo. The PR only updates expected skill-path literals and adds no It blocks, waits, resource setup, or assertions.
Microshift Test Compatibility	✅ Passed	The diff adds no Ginkgo e2e tests. It only changes the advisor prompt and expected skill-path strings in existing Go unit tests.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The committed diff only renames skill paths and prompt text; it adds no Ginkgo e2e tests or changed multi-node assumptions.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only skill prompt/path strings and matching test expectations; it adds no deployment, replica, affinity, topology spread, selector, toleration, or PDB scheduling constraint.
Ote Binary Stdout Contract	✅ Passed	The diff changes only prompt and skill-path literals plus test expectations; it adds no stdout/logging calls and does not modify OTE entrypoint or suite setup.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff only changes skill-path strings and Go unit-test expectations. It adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity.
No-Weak-Crypto	✅ Passed	The diff only renames the cluster-update-advisor prompt and skill paths; it adds no MD5, SHA1, DES, RC4, Blowfish, ECB, custom crypto, or secret comparisons.
Container-Privileges	✅ Passed	The PR changes only Go prompt and skill-path strings. Added lines contain no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation settings.
No-Sensitive-Data-In-Logs	✅ Passed	The parent-to-HEAD diff changes only skill names and expected test paths; it adds no logging and exposes no passwords, tokens, PII, hostnames, or customer data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci]

@jrangelramos: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[jrangelramos]

closed as duplicate of #1446