OTA-2108: restrict console plugin NetworkPolicy to openshift-console namespace

[jrangelramos]

Summary

• The allow-console-ingress NetworkPolicy opened port 9001/TCP to any pod in the cluster,
  despite the annotation stating it allows ingress "from the console" only.
• Added a from: namespaceSelector matching kubernetes.io/metadata.name: openshift-console
  to enforce least-privilege networking and align the policy with its stated intent.

Fixes https://redhat.atlassian.net/browse/OTA-2108

Test plan

• Unit tests pass (gotestsum --packages="./pkg/agenticrun/..." — 49 tests)
• Deploy to a test cluster and verify the console plugin remains accessible from the OpenShift console
• Verify that pods in other namespaces can no longer reach port 9001

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Updated network access rules to allow incoming traffic only from the OpenShift Console namespace.
  • Continued allowing TCP traffic on port 9001.

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@jrangelramos: This pull request references OTA-2108 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the weakness to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

• The allow-console-ingress NetworkPolicy opened port 9001/TCP to any pod in the cluster,
  despite the annotation stating it allows ingress "from the console" only.
• Added a from: namespaceSelector matching kubernetes.io/metadata.name: openshift-console
  to enforce least-privilege networking and align the policy with its stated intent.

Fixes https://redhat.atlassian.net/browse/OTA-2108

Test plan

• Unit tests pass (gotestsum --packages="./pkg/agenticrun/..." — 49 tests)
• Deploy to a test cluster and verify the console plugin remains accessible from the OpenShift console
• Verify that pods in other namespaces can no longer reach port 9001

🤖 Generated with Claude Code

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 29713747-056b-4336-8a72-184a51b325ec

📥 Commits

Reviewing files that changed from the base of the PR and between 208b01a and 93f82e6.

📒 Files selected for processing (1)

• pkg/agenticrun/bindata/assets/networkpolicy-allow-console.yaml

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

---

Walkthrough

The NetworkPolicy now allows ingress only from the openshift-console namespace and retains TCP port 9001.

Changes

NetworkPolicy ingress restriction

Layer / File(s)	Summary
Restrict console ingress pkg/agenticrun/bindata/assets/networkpolicy-allow-console.yaml	The ingress rule selects the openshift-console namespace and retains TCP port 9001.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 93f82

This localized change restricts console plugin network access to the openshift-console namespace. No actionable merge-blocking risk remains after normal checks and review.

🚥 Pre-merge checks | ✅ 15

✅ Passed checks (15 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly and concisely describes restricting the console plugin NetworkPolicy to the openshift-console namespace.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names	✅ Passed	The PR diff changes only a NetworkPolicy YAML file; it adds a namespaceSelector and changes no Ginkgo test titles or test files.
Test Structure And Quality	✅ Passed	The commit changes only a NetworkPolicy YAML asset; it adds no Ginkgo tests or test code, so these test-quality requirements are not applicable.
Microshift Test Compatibility	✅ Passed	The commit changes only a NetworkPolicy YAML asset and adds no Ginkgo e2e tests or test files, so MicroShift test compatibility is not applicable.
Single Node Openshift (Sno) Test Compatibility	✅ Passed	The commit changes only one NetworkPolicy YAML file; the diff adds no Ginkgo e2e tests or test paths, so SNO compatibility criteria do not apply.
Topology-Aware Scheduling Compatibility	✅ Passed	The commit changes only a NetworkPolicy ingress selector, adding the openshift-console namespace; it introduces no deployment scheduling constraints covered by this check.
Ote Binary Stdout Contract	✅ Passed	The PR diff changes only a NetworkPolicy YAML file; it adds a namespaceSelector and introduces no process-level stdout writes.
Ipv6 And Disconnected Network Test Compatibility	✅ Passed	The diff changes only a NetworkPolicy YAML file. It adds no Ginkgo e2e tests, IPv4 assumptions, or external connectivity requirements.
No-Weak-Crypto	✅ Passed	The PR changes only NetworkPolicy YAML by adding an openshift-console namespace selector; no weak-crypto algorithm, custom crypto, or secret comparison is introduced.
Container-Privileges	✅ Passed	The only change adds a namespaceSelector to NetworkPolicy ingress. It introduces no privileged, host namespace, SYS_ADMIN, root, or allowPrivilegeEscalation setting.
No-Sensitive-Data-In-Logs	✅ Passed	The PR only adds a NetworkPolicy namespaceSelector; it introduces no logging or sensitive-data output, and the existing annotation contains no sensitive data.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[ankitathomas]

/lgtm

[openshift-merge-bot]

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-agnostic-operator
/test e2e-agnostic-ovn
/test e2e-agnostic-ovn-techpreview-serial-1of3
/test e2e-agnostic-ovn-techpreview-serial-2of3
/test e2e-agnostic-ovn-techpreview-serial-3of3
/test e2e-agnostic-ovn-upgrade-into-change
/test e2e-agnostic-ovn-upgrade-out-of-change
/test e2e-aws-ovn-techpreview
/test e2e-hypershift
/test e2e-hypershift-conformance

[openshift-ci]

@jrangelramos: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-hypershift-conformance	93f82e6	link	true	/test e2e-hypershift-conformance
ci/prow/e2e-agnostic-ovn-techpreview-serial-1of3	93f82e6	link	true	/test e2e-agnostic-ovn-techpreview-serial-1of3

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[wking]

I don't see anything here about why @jhadvig didn't tune access like this (or even more tightly, can't we also match the app: console label?).

But also, the long-established monitoring ConsolePlugin doesn't bother to set from for their ConsolePlugin, so 🤷, doesn't seem like a particularly sensitive thing to protect.

[wking]

Seems like there are lots of valid options in this space, and I'm not particular about which path we take. I'm fine with what we had before this pull. I'm fine with what this pull is delivering. And I'd be fine if folks wanted to tighten it down more. As long as the testing shows it still working, that's enough for me. The odds of someone exploiting the low-priviledge console-plugin service to harm a cluster or capture sensitive data seem very low.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankitathomas, jrangelramos, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment