Skip to content

NO-JIRA: Enable SELinuxMount tests - #605

Draft
jsafrane wants to merge 1 commit into
openshift:mainfrom
jsafrane:enable-selinuxmount-tests
Draft

NO-JIRA: Enable SELinuxMount tests#605
jsafrane wants to merge 1 commit into
openshift:mainfrom
jsafrane:enable-selinuxmount-tests

Conversation

@jsafrane

Copy link
Copy Markdown
Contributor

No description provided.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

@openshift-ci-robot

Copy link
Copy Markdown

@jsafrane: This pull request explicitly references no jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 24, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2026
@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 24, 2026
@jsafrane

Copy link
Copy Markdown
Contributor Author

/test e2e-aws-csi
/test e2e-azure-csi-hypershift

@coderabbitai

coderabbitai Bot commented Aug 24, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 326f5c8b-3cdb-4439-9fce-b26070ca2070

📥 Commits

Reviewing files that changed from the base of the PR and between f7f9dc5 and 14497a5.

⛔ Files ignored due to path filters (10)
  • assets/overlays/aws-ebs/generated/standalone/servicemonitor.yaml is excluded by !**/generated/**
  • assets/overlays/aws-efs/generated/standalone/servicemonitor.yaml is excluded by !**/generated/**
  • assets/overlays/azure-disk/generated/hypershift/node_servicemonitor.yaml is excluded by !**/generated/**
  • assets/overlays/azure-disk/generated/standalone/node_servicemonitor.yaml is excluded by !**/generated/**
  • assets/overlays/azure-disk/generated/standalone/servicemonitor.yaml is excluded by !**/generated/**
  • assets/overlays/azure-file/generated/standalone/servicemonitor.yaml is excluded by !**/generated/**
  • assets/overlays/gcp-pd/generated/standalone/servicemonitor.yaml is excluded by !**/generated/**
  • assets/overlays/openstack-cinder/generated/standalone/servicemonitor.yaml is excluded by !**/generated/**
  • assets/overlays/openstack-manila/generated/standalone/servicemonitor.yaml is excluded by !**/generated/**
  • assets/overlays/samba/generated/standalone/servicemonitor.yaml is excluded by !**/generated/**
📒 Files selected for processing (7)
  • assets/common/metrics/service_monitor_add_port.yaml.patch
  • test/e2e/aws-ebs/manifest.yaml
  • test/e2e/azure-disk/manifest.yaml
  • test/e2e/gcp-pd/hyperdisk-manifest.yaml
  • test/e2e/gcp-pd/image-snapshot-manifest.yaml
  • test/e2e/gcp-pd/manifest.yaml
  • test/e2e/openstack-cinder/manifest.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


📝 Walkthrough

Walkthrough

The ServiceMonitor TLS serverName namespace variable changes from ${NAMESPACE} to ${NODE_NAMESPACE}. The AWS EBS, Azure Disk, GCP PD, GCP Hyperdisk, GCP image snapshot, and OpenStack Cinder end-to-end test manifests enable the seLinuxMount capability.

Merge Risk: ⚪ Minimal · up to 14497

The change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Description check ❓ Inconclusive No pull request description was provided, so it does not explain the changeset. Add a brief description that explains the SELinuxMount test updates and the ServiceMonitor serverName correction.
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: enabling SELinuxMount tests.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (7 skipped: 7 unsupported.)
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The PR changes only YAML capability flags and ServiceMonitor serverName substitutions; the commit adds no Ginkgo title calls or dynamic test-title construction.
Test Structure And Quality ✅ Passed The PR diff changes only YAML manifests and generated ServiceMonitor YAML; it adds seLinuxMount flags and changes a namespace variable, with no changed Ginkgo It blocks or wait/assertion code.
Microshift Test Compatibility ✅ Passed The commit changes only YAML configuration: six manifests enable seLinuxMount and metrics templates change serverName; no Ginkgo tests or unsupported MicroShift API references were added.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The PR changes only YAML/PATCH files; test changes add six seLinuxMount capability keys and no new Ginkgo tests or multi-node assumptions.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only ServiceMonitor TLS names and CSI E2E capability flags; no affinity, spread, replica, node selector, toleration, or PDB scheduling constraints were introduced.
Ote Binary Stdout Contract ✅ Passed The PR diff contains only YAML and patch changes; it adds seLinuxMount flags and changes metric serverName, with no process-level binary or stdout code changes.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The PR adds only seLinuxMount manifest flags and cluster-internal ServiceMonitor DNS substitutions; it adds no Ginkgo tests or IPv4/public connectivity requirement.
No-Weak-Crypto ✅ Passed The commit only changes ServiceMonitor DNS names and enables seLinuxMount; added lines contain no MD5, SHA1, DES, RC4, Blowfish, ECB, or custom crypto logic.
Container-Privileges ✅ Passed Diff versus main adds only ServiceMonitor serverName changes and e2e seLinuxMount metadata; no changed line introduces privileged, host namespaces, SYS_ADMIN, root execution, or allowPrivilegeEscal...
No-Sensitive-Data-In-Logs ✅ Passed The diff adds only TLS ServiceMonitor serverName values and seLinuxMount test flags; it adds no logging calls, log configuration, or sensitive data output.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

@jsafrane: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-csi-hypershift 14497a5 link false /test e2e-azure-csi-hypershift
ci/prow/e2e-aws-csi 14497a5 link true /test e2e-aws-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants