[release-5.0] OCPBUGS-114002: GCP-1074: feat(gcp-pd): enable HyperShift support for GCP PD CSI driver operator

[ckandag]

Manual cherry-pick of #601 to release-5.0.

The automatic /cherry-pick bot flow was tried first (see #606, now closed) but per CSI team guidance a manual cherry-pick is safer here since the original PR (#601) was merged without a bug reference targeting 5.1, which could interact unpredictably with the bot's Jira-linking automation on the backport.

Changes

Same as #601:

• Add --guest-kubeconfig flag so the operator can run against a HyperShift guest cluster.
• Remove StandaloneOnly gating in GetGCPPDGeneratorConfig and generate the hypershift asset overlay alongside standalone.
• Add controller_add_hypershift_controller_minter.yaml patch: wires the token-minter sidecar and hosted-kubeconfig volume, fixes the GOOGLE_APPLICATION_CREDENTIALS filename mismatch with HyperShift's WIF credentials secret, disables hostNetwork (blocked by GKE Autopilot), sets explicit ephemeral-storage requests per container (GKE Autopilot pod-level cap), and disables the node service on the controller (--run-node-service=false, since hostNetwork is off).
• Remove the HyperShift-unsupported error in GetGCPPDOperatorControllerConfig and gate OldControllerPrivilegedBindingRemoval to Standalone only.
• Add unit tests covering Standalone vs HyperShift controller config.

Note on generated assets

release-5.0's shared base templates (assets/base/controller.yaml, assets/base/node.yaml) still use the deprecated serviceAccount: field name, whereas main has since been updated to serviceAccountName:. Ran hack/update-generated-assets.sh against this branch (rather than copying main's regenerated output verbatim) so the two are equivalent — this avoids pulling in an unrelated base-template rename and keeps verify-generated-assets passing on release-5.0.

make verify and go test ./pkg/driver/gcp-pd/... pass locally.

Bug: https://redhat.atlassian.net/browse/OCPBUGS-114002 (backport of GCP-1074)

Made with Cursor

[openshift-merge-bot]

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: LGTM mode

[openshift-ci-robot]

@ckandag: This pull request references Jira Issue OCPBUGS-114002, which is invalid:

• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-114002 to depend on a bug targeting a version in 5.1.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Manual cherry-pick of #601 to release-5.0.

The automatic /cherry-pick bot flow was tried first (see #606, now closed) but per CSI team guidance a manual cherry-pick is safer here since the original PR (#601) was merged without a bug reference targeting 5.1, which could interact unpredictably with the bot's Jira-linking automation on the backport.

Changes

Same as #601:

• Add --guest-kubeconfig flag so the operator can run against a HyperShift guest cluster.
• Remove StandaloneOnly gating in GetGCPPDGeneratorConfig and generate the hypershift asset overlay alongside standalone.
• Add controller_add_hypershift_controller_minter.yaml patch: wires the token-minter sidecar and hosted-kubeconfig volume, fixes the GOOGLE_APPLICATION_CREDENTIALS filename mismatch with HyperShift's WIF credentials secret, disables hostNetwork (blocked by GKE Autopilot), sets explicit ephemeral-storage requests per container (GKE Autopilot pod-level cap), and disables the node service on the controller (--run-node-service=false, since hostNetwork is off).
• Remove the HyperShift-unsupported error in GetGCPPDOperatorControllerConfig and gate OldControllerPrivilegedBindingRemoval to Standalone only.
• Add unit tests covering Standalone vs HyperShift controller config.

Note on generated assets

release-5.0's shared base templates (assets/base/controller.yaml, assets/base/node.yaml) still use the deprecated serviceAccount: field name, whereas main has since been updated to serviceAccountName:. Ran hack/update-generated-assets.sh against this branch (rather than copying main's regenerated output verbatim) so the two are equivalent — this avoids pulling in an unrelated base-template rename and keeps verify-generated-assets passing on release-5.0.

make verify and go test ./pkg/driver/gcp-pd/... pass locally.

Bug: https://redhat.atlassian.net/browse/OCPBUGS-114002 (backport of GCP-1074)

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: ba26606d-8783-4059-bff2-9b8251c54f66

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[rhrmo]

/jira refresh

[openshift-ci-robot]

@rhrmo: This pull request references Jira Issue OCPBUGS-114002, which is invalid:

• expected dependent Jira Issue OCPBUGS-112748 to be in one of the following states: MODIFIED, ON_QA, VERIFIED, but it is Closed (Done) instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhrmo]

/jira refresh

[openshift-ci-robot]

@rhrmo: This pull request references Jira Issue OCPBUGS-114002, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (5.0.0) matches configured target version for branch (5.0.0)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note type set to "Release Note Not Required"
• dependent bug Jira Issue OCPBUGS-112748 is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
• dependent Jira Issue OCPBUGS-112748 targets the "5.1.0" version, which is one of the valid target versions: 5.1.0
• bug has dependents

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[rhrmo]

/lgtm
/approve

[openshift-merge-bot]

Scheduling required tests:
/test e2e-aws-csi
/test e2e-aws-ovn-upgrade
/test e2e-azure
/test e2e-azure-csi
/test e2e-azure-file-csi
/test e2e-azure-file-nfs-csi
/test e2e-azure-ovn-upgrade
/test e2e-gcp
/test e2e-gcp-csi
/test e2e-gcp-ovn-upgrade

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ckandag, rhrmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [rhrmo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[ckandag]

/test e2e-azure-ovn-upgrade

[openshift-merge-bot]

/retest-required

Remaining retests: 0 against base HEAD 8093776 and 2 for PR HEAD 71c236a in total

[ckandag]

/test e2e-azure-file-nfs-csi

[ckandag]

/test e2e-azure-file-csi

[ckandag]

/test e2e-azure-file-csi

[ckandag]

/verified later @ckandag

[openshift-ci-robot]

@ckandag: This PR has been marked to be verified later by @ckandag.

Details

In response to this:

/verified later @ckandag

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[ckandag]

/test e2e-azure-file-csi

[rhrmo]

/test e2e-azure-file-csi

[openshift-ci]

@ckandag: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure-file-csi	71c236a	link	true	/test e2e-azure-file-csi

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.