STOR-2973: CI implementation: Validate Storage on GCP Dedicated by rvagner78 · Pull Request #81996 · openshift/release

rvagner78 · 2026-07-16T10:00:25Z

Add CSI storage certification workflow for Google Cloud Dedicated (GCD).

New workflow openshift-e2e-gcd-csi that reuses existing CSI test infrastructure with GCD cluster provisioning
Uses COMPUTE_DISK_TYPE: hyperdisk-balanced to select the correct CSI driver test manifest (GCD only supports hyperdisk-balanced disks)
Job e2e-gcd-csi added to csi-operator release-5.0 config (optional: true, always_run: false)

Summary by CodeRabbit

Adds optional and weekly CSI test jobs for csi-operator release-5.0 on Google Cloud Dedicated clusters.
Adds the openshift-e2e-gcd-csi workflow with GCP PD CSI manifests and hyperdisk-balanced disks.
Skips tests that require GCP infrastructure unavailable on GCD.
Adds storage team ownership and approval metadata.

openshift-ci-robot · 2026-07-16T10:00:30Z

@rvagner78: This pull request references STOR-2973 which is a valid jira issue.

Details

In response to this:

Add CSI storage certification workflow for Google Cloud Dedicated (GCD).

New workflow openshift-e2e-gcd-csi that reuses existing CSI test infrastructure with GCD cluster provisioning

Uses COMPUTE_DISK_TYPE: hyperdisk-balanced to select the correct CSI driver test manifest (GCD only supports hyperdisk-balanced disks)

Job e2e-gcd-csi added to csi-operator release-5.0 config (optional: true, always_run: false)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-07-16T10:00:54Z

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 76270aa9-638a-45da-9637-25f16df11542

📥 Commits

Reviewing files that changed from the base of the PR and between 458419d and 6eb38ea.

📒 Files selected for processing (2)

ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-5.0.yaml
ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-5.0__periodics.yaml

💤 Files with no reviewable changes (2)

ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-5.0__periodics.yaml
ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-5.0.yaml

Walkthrough

Adds a GCD CSI workflow and registers optional release and weekly periodic tests. Both jobs use the gcd cluster profile and the openshift-e2e-gcd-csi workflow.

Changes

GCD CSI coverage

Layer / File(s)	Summary
Define the GCD CSI workflow `ci-operator/step-registry/openshift/e2e/gcd/csi/*`	Adds the workflow, metadata, and ownership configuration. The workflow runs `openshift/csi` with GCP PD CSI manifests, uses `hyperdisk-balanced` disks, and performs validation, diagnostics, and cleanup.
Register release and periodic jobs `ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-5.0.yaml`, `ci-operator/config/openshift/csi-operator/openshift-csi-operator-release-5.0__periodics.yaml`	Adds the optional `e2e-gcd-csi` release test and the weekly `periodic-e2e-gcd-csi` job. The periodic job reports failures and errors to the storage triage channel.

Estimated code review effort: 2 (Simple) | ~10 minutes

Sequence Diagram(s)

sequenceDiagram
  participant TestJob
  participant GCDCSIWorkflow
  participant GCPCluster
  participant CSISuite
  TestJob->>GCDCSIWorkflow: Run openshift-e2e-gcd-csi
  GCDCSIWorkflow->>GCPCluster: Provision and configure GCP cluster
  GCDCSIWorkflow->>CSISuite: Run openshift/csi
  GCDCSIWorkflow->>GCPCluster: Validate objects, gather core dumps, and deprovision resources

Possibly related PRs

openshift/release#83254: Adds an optional operator-specific end-to-end test job with a separate workflow.
openshift/release#83303: Adds GCD-based periodic end-to-end coverage for a different workflow.

Suggested labels: lgtm, approved, rehearsals-ack

Suggested reviewers: dgoodwin, mpatlasov

🚥 Pre-merge checks | ✅ 5 | ❌ 10

❌ Failed checks (10 inconclusive)

Check name	Status	Explanation	Resolution
Stable And Deterministic Test Names	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Test Structure And Quality	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Microshift Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Single Node Openshift (Sno) Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Topology-Aware Scheduling Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ote Binary Stdout Contract	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Ipv6 And Disconnected Network Test Compatibility	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Weak-Crypto	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
Container-Privileges	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.
No-Sensitive-Data-In-Logs	❓ Inconclusive	Repository clone failed, so this custom check could not run with code access.	Retry the review run. If this persists, inspect pre-merge custom-check logs for infrastructure or agent runtime failures.

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly summarizes the CI implementation for validating storage on GCP Dedicated, which matches the main changes.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

rvagner78 · 2026-08-10T13:39:40Z

/pj-rehearse pull-ci-openshift-csi-operator-release-5.0-e2e-gcd-csi

openshift-merge-bot · 2026-08-10T13:41:54Z

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

openshift-merge-bot · 2026-08-10T13:42:34Z

@rvagner78, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto 9be95eec3139a2af7022da80441faa9a86c4a504 due to conflicts

coderabbitai · 2026-08-10T14:03:14Z

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

openshift-merge-bot · 2026-08-10T14:08:03Z

@rvagner78: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

rvagner78 · 2026-08-10T14:26:51Z

/pj-rehearse pull-ci-openshift-csi-operator-release-5.0-e2e-gcd-csi

openshift-merge-bot · 2026-08-10T14:28:51Z

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rvagner78 · 2026-08-11T09:51:20Z

/pj-rehearse pull-ci-openshift-csi-operator-release-5.0-e2e-gcd-csi

openshift-merge-bot · 2026-08-11T09:51:24Z

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

jsafrane · 2026-08-11T13:31:27Z

/lgtm
/approve

jsafrane · 2026-08-11T13:32:17Z

/pj-rehearse ack

openshift-merge-bot · 2026-08-11T13:34:24Z

@jsafrane: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

patrickdillon · 2026-08-11T13:55:54Z

    workflow: openshift-e2e-gcp-manual-oidc-workload-identity-persistent-disk
+- always_run: false
+  as: e2e-gcd-csi
+  optional: true


You may want to SKIP the tests we're skipping here:
https://github.com/openshift/release/blob/main/ci-operator/config/openshift/installer/openshift-installer-main.yaml#L556

Also, I think we're going to need to skip the test API LBs follow /readyz of kube-apiserver and stop sending requests so you should probably add that in as well

Thanks, updated.

Thanks, updated.

Finally it looks like we don't need SKIP_TEST in our job, because we don't run them anyway.
The /pj-rehearse pull-ci-openshift-csi-operator-release-5.0-e2e-gcd-csi passed and CSI storage tests were executed.

…st on GCD.

openshift-merge-bot · 2026-08-11T19:08:32Z

@gnufied: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rvagner78 · 2026-08-12T08:00:57Z

/pj-rehearse pull-ci-openshift-csi-operator-release-5.0-e2e-gcd-csi

openshift-merge-bot · 2026-08-12T08:00:59Z

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rvagner78 · 2026-08-12T08:56:50Z

/pj-rehearse pull-ci-openshift-csi-operator-release-5.0-e2e-gcd-csi

openshift-merge-bot · 2026-08-12T08:56:53Z

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rvagner78 · 2026-08-12T11:32:38Z

/pj-rehearse pull-ci-openshift-csi-operator-release-5.0-e2e-gcd-csi

openshift-merge-bot · 2026-08-12T11:32:41Z

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

gnufied · 2026-08-12T14:33:50Z

@rvagner78 the CI says:

Error: no tests were found matching the TEST_SKIPS regex:
Ensure HTTPRoute object is created\|The HAProxy router should pass the http2 tests\|The HAProxy router should pass the h2spec conformance tests\|should serve a basic image on each replica with a private image\|Validate user is able to extract rhel8 and rhel9 oc from the ocp payload\|regional PD should store data and sync across zones\|L2 primary UDN with custom network, cluster-networked pods, NodePort service\|cluster-config-operator should report complete ClusterOperator status\|API LBs follow /readyz of kube-apiserver and stop sending requests
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2026-08-12T13:43:26Z"}

…sn't exist on GCD.

rvagner78 · 2026-08-12T15:05:54Z

@rvagner78 the CI says:

Error: no tests were found matching the TEST_SKIPS regex:
Ensure HTTPRoute object is created\|The HAProxy router should pass the http2 tests\|The HAProxy router should pass the h2spec conformance tests\|should serve a basic image on each replica with a private image\|Validate user is able to extract rhel8 and rhel9 oc from the ocp payload\|regional PD should store data and sync across zones\|L2 primary UDN with custom network, cluster-networked pods, NodePort service\|cluster-config-operator should report complete ClusterOperator status\|API LBs follow /readyz of kube-apiserver and stop sending requests
{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"sigs.k8s.io/prow/pkg/entrypoint/run.go:84","func":"sigs.k8s.io/prow/pkg/entrypoint.Options.internalRun","level":"error","msg":"Error executing test process","severity":"error","time":"2026-08-12T13:43:26Z"}

looks like we don't need SKIP_TEST in our job, because we don't run them anyway, removed

openshift-merge-bot · 2026-08-12T15:06:46Z

@rvagner78: pj-rehearse could not automatically process this event because the request waited in queue for longer than 5 minutes. Use /pj-rehearse to trigger rehearsals manually.

rvagner78 · 2026-08-12T15:08:35Z

/pj-rehearse pull-ci-openshift-csi-operator-release-5.0-e2e-gcd-csi

openshift-merge-bot · 2026-08-12T15:13:30Z

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rvagner78 · 2026-08-13T07:29:03Z

/pj-rehearse pull-ci-openshift-csi-operator-release-5.0-e2e-gcd-csi

openshift-merge-bot · 2026-08-13T07:29:07Z

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rvagner78 · 2026-08-13T07:29:13Z

/retest

rvagner78 · 2026-08-13T10:27:35Z

/pj-rehearse pull-ci-openshift-csi-operator-release-5.0-e2e-gcd-csi

openshift-merge-bot · 2026-08-13T10:27:38Z

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

jsafrane · 2026-08-13T11:55:10Z

/lgtm

rvagner78 · 2026-08-13T15:14:29Z

/pj-rehearse ack

openshift-merge-bot · 2026-08-13T15:14:32Z

@rvagner78: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

rochacbruno · 2026-08-13T15:24:38Z

/lgtm

rochacbruno · 2026-08-13T15:25:46Z

/approve

openshift-ci · 2026-08-13T15:26:27Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, rochacbruno, rvagner78

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~ci-operator/config/openshift/csi-operator/OWNERS~~ [jsafrane]
~~ci-operator/jobs/openshift/csi-operator/OWNERS~~ [jsafrane]
~~ci-operator/step-registry/openshift/e2e/gcd/OWNERS~~ [rochacbruno]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci · 2026-08-13T15:46:41Z

@rvagner78: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jul 16, 2026

openshift-ci Bot requested review from dgoodwin and mpatlasov July 16, 2026 10:01

rochacbruno reviewed Jul 16, 2026

View reviewed changes

Comment thread ci-operator/step-registry/openshift/e2e/gcd/csi/openshift-e2e-gcd-csi-workflow.yaml Outdated

openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 20, 2026

rvagner78 force-pushed the gcd-csi-e2e branch from 732843d to 594840f Compare July 28, 2026 10:39

openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 28, 2026

rvagner78 added 2 commits August 10, 2026 15:55

STOR-2973: Add CSI storage certification workflow for GCD

4e24235

STOR-2973: Add CSI storage certification workflow for GCD, env variables

e347739

rvagner78 force-pushed the gcd-csi-e2e branch from 594840f to e347739 Compare August 10, 2026 14:03

openshift-ci Bot assigned jsafrane Aug 11, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 11, 2026

patrickdillon reviewed Aug 11, 2026

View reviewed changes

STOR-2968: skip tests that assume GCP infrastructure that doesn't exi…

458419d

…st on GCD.

openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2026

STOR-2968: revert: skip tests that assume GCP infrastructure that doe…

6eb38ea

…sn't exist on GCD.

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 13, 2026

openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 13, 2026

openshift-ci Bot assigned rochacbruno Aug 13, 2026

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 13, 2026

openshift-merge-bot Bot merged commit effc4bb into openshift:main Aug 13, 2026
19 checks passed

Uh oh!

Conversation

rvagner78 commented Jul 16, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by CodeRabbit

Uh oh!

openshift-ci-robot commented Jul 16, 2026 • edited by atlassian Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai Bot commented Jul 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reviews paused

Walkthrough

Changes

Sequence Diagram(s)

❌ Failed checks (10 inconclusive)

Uh oh!

Uh oh!

rvagner78 commented Aug 10, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 10, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 10, 2026

Uh oh!

coderabbitai Bot commented Aug 10, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 10, 2026

Uh oh!

rvagner78 commented Aug 10, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 10, 2026

Uh oh!

rvagner78 commented Aug 11, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 11, 2026

Uh oh!

jsafrane commented Aug 11, 2026

Uh oh!

jsafrane commented Aug 11, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 11, 2026

Uh oh!

patrickdillon Aug 11, 2026

Choose a reason for hiding this comment

Uh oh!

rvagner78 Aug 12, 2026

Choose a reason for hiding this comment

Uh oh!

rvagner78 Aug 13, 2026

Choose a reason for hiding this comment

Uh oh!

openshift-merge-bot Bot commented Aug 11, 2026

Uh oh!

rvagner78 commented Aug 12, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 12, 2026

Uh oh!

rvagner78 commented Aug 12, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 12, 2026

Uh oh!

rvagner78 commented Aug 12, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 12, 2026

Uh oh!

gnufied commented Aug 12, 2026

Uh oh!

rvagner78 commented Aug 12, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 12, 2026

Uh oh!

rvagner78 commented Aug 12, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 12, 2026

Uh oh!

rvagner78 commented Aug 13, 2026

Uh oh!

openshift-merge-bot Bot commented Aug 13, 2026

Uh oh!

rvagner78 commented Aug 13, 2026

rvagner78 commented Jul 16, 2026 •

edited by coderabbitai Bot

Loading

openshift-ci-robot commented Jul 16, 2026 •

edited by atlassian Bot

Loading

coderabbitai Bot commented Jul 16, 2026 •

edited

Loading