Revert "Add tls-scanner-run to RHOAI e2e job" - #82675
Conversation
This reverts commit fb1c6c9.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
WalkthroughThe operator CI pipeline removes the TLS scanner base image, scan-related environment variables, and ChangesTLS scanner wiring removal
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: carlkyrillos, davidebianchi The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
[REHEARSALNOTIFIER]
Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals. Interacting with pj-rehearseComment: Once you are satisfied with the results of the rehearsals, comment: |
|
/pj-rehearse ack |
|
@carlkyrillos: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel. |
|
@davidebianchi: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
…shift#82675) This reverts commit fb1c6c9.
…shift#82675) This reverts commit fb1c6c9.
The tls-scanner-run step was reverted in openshift#82675 because it was blocking PRs before 3.5 GA code freeze. The root cause was two categories of findings: 1. rhods-operator-catalog port 50051 - OLM file-based catalog gRPC, plain-text by design in CI (not a compliance violation) 2. rhods-operator port 8080 - metrics endpoint, now fixed by opendatahub-operator#3888 (SecureServing for metrics, merged 2026-07-30) Re-add tls-scanner-run as a best_effort post step so it reports findings without blocking PRs while we confirm all legitimate violations are gone. Once clean, promote back to a required step. Co-Authored-By: Claude <claude-sonnet-4-6> <noreply@anthropic.com>
…ions Restores tls-scanner-run to the opendatahub-operator-rhoai-e2e job (reverted in openshift#82675 due to blocking PRs before 3.5 GA code freeze). Root cause of the original failure: the scanner was also scanning redhat-ods-operator, which contains rhods-operator-catalog (OLM file-based catalog server, plain-text gRPC port 50051 by design in CI). This is not a compliance target. Fix: scope SCAN_NAMESPACE to redhat-ods-applications only, where the actual RHOAI operator workloads run. The rhods-operator metrics endpoint (8080) that was also flagged is now fixed via opendatahub-operator#3888 (SecureServing for metrics, merged 2026-07-30). tls-scanner-run is added back as the last test step, matching the original openshift#82555 structure (same cluster, blocking, enforced). Co-Authored-By: Claude <claude-sonnet-4-6> <noreply@anthropic.com>
The check is failing in opendatahub-operator and blocking PRs, without an evidence that it passed before.
We'll revert it, and it should be restored in a future PR
Summary by CodeRabbit
Removes the failing
tls-scanner-runcheck and its related configuration from theopendatahub-operatorRHOAI end-to-end CI job, preventing it from blocking pull requests.