Skip to content

New periodic job for testing ARO-HCP on OCP 5.0 - #83253

Open
miquelsi wants to merge 1 commit into
openshift:mainfrom
miquelsi:aro-hcp-ocp-5
Open

New periodic job for testing ARO-HCP on OCP 5.0#83253
miquelsi wants to merge 1 commit into
openshift:mainfrom
miquelsi:aro-hcp-ocp-5

Conversation

@miquelsi

@miquelsi miquelsi commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

New periodic job for testing ARO-HCP on OCP 5.0

Summary by CodeRabbit

Adds a weekly production periodic job in the ARO-HCP CI configuration to test OCP 5.0 with candidate channels, production subscriptions, and a four-hour timeout.

Updates the persistent ARO-HCP test step to support the latest OpenShift Z stream and independent control-plane and node-pool versions.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 11, 2026
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Hi @miquelsi. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
openshift-ci Bot requested review from janboll and mmazur August 11, 2026 12:30
@openshift-ci

openshift-ci Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: miquelsi
Once this PR has been reviewed and has the lgtm label, please assign deads2k for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a0255203-1732-4e51-93a3-510c3192d136

📥 Commits

Reviewing files that changed from the base of the PR and between 16a94ea and 61fc527.

⛔ Files ignored due to path filters (1)
  • ci-operator/jobs/Azure/ARO-HCP/Azure-ARO-HCP-main-periodics.yaml is excluded by !ci-operator/jobs/**
📒 Files selected for processing (2)
  • ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml
  • ci-operator/step-registry/aro-hcp/test/persistent/aro-hcp-test-persistent-ref.yaml
🚧 Files skipped from review as they are similar to previous changes (2)
  • ci-operator/step-registry/aro-hcp/test/persistent/aro-hcp-test-persistent-ref.yaml
  • ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml

Included review availability: Your plan provides up to 2 included reviews per hour; 0 remain after this review.


Walkthrough

The PR adds separate ARO-HCP control-plane and node-pool version variables. It schedules a weekly production parallel E2E job with candidate channels and version 5.0.

Changes

ARO-HCP candidate E2E workflow

Layer / File(s) Summary
Version selection and production scheduling
ci-operator/step-registry/aro-hcp/test/persistent/aro-hcp-test-persistent-ref.yaml, ci-operator/config/Azure/ARO-HCP/Azure-ARO-HCP-main__periodic.yaml
The persistent test step defines OpenShift stream, control-plane, and node-pool version variables. The periodic configuration adds a Sunday production parallel E2E job with latest Z-stream selection, production subscriptions, Vault settings, production reporting, and a four-hour timeout.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to 61fc5

This PR adds periodic testing configuration, and no actionable merge-blocking risk remains based on the supplied evidence.

Suggested reviewers: mmazur, janboll

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the new periodic ARO-HCP test job for OCP 5.0.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed The commit adds CI job metadata and environment declarations only; the diff introduces no Ginkgo It(), Describe(), Context(), or When() test titles or dynamic title construction.
Test Structure And Quality ✅ Passed The PR changes only YAML configuration; no Go/Ginkgo source or Ginkgo constructs changed. The new workflow and test step both define a 4-hour timeout.
Microshift Test Compatibility ✅ Passed The parent-to-HEAD diff changes only three CI YAML files and adds no Ginkgo tests or test source, so MicroShift test compatibility checks do not apply.
Single Node Openshift (Sno) Test Compatibility ✅ Passed The commit changes only CI YAML job configuration and environment declarations; the diff adds no Ginkgo e2e tests or test bodies requiring multi-node behavior.
Topology-Aware Scheduling Compatibility ✅ Passed The PR changes only CI periodic/step configuration and environment variables; the diff adds no deployment manifests, operator/controller code, or topology scheduling constraints.
Ote Binary Stdout Contract ✅ Passed The PR changes only YAML job and environment declarations; the diff adds no process-level stdout writes, logging setup, or OTE binary code.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed The HEAD diff adds only periodic-job and step-reference YAML; it adds no Go files or Ginkgo It/Describe/Context/When declarations, so this check is not triggered.
No-Weak-Crypto ✅ Passed The HEAD^..HEAD diff adds only periodic-job and environment YAML; the exact added-line scan found no MD5, SHA1, DES, RC4, Blowfish, ECB, crypto, or constant-time comparison usage.
Container-Privileges ✅ Passed The diff adds no privileged, hostPID, hostNetwork, hostIPC, SYS_ADMIN, allowPrivilegeEscalation, securityContext, or root-user declaration.
No-Sensitive-Data-In-Logs ✅ Passed The diff adds job and environment declarations only. It adds no logging code or secret values, and the unchanged test script disables xtrace while reading and using the client secret.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@janboll

janboll commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 11, 2026
@miquelsi

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miquelsi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@miquelsi

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miquelsi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@miquelsi

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miquelsi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@miquelsi

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miquelsi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miquelsi, pj-rehearse: unable prepare a candidate for rehearsal; rehearsals will not be run. This could be due to a branch that needs to be rebased. ERROR:

couldn't rebase candidate onto 142f76e9b661c11887f44cd8e62f2aa9dfcec6f8 due to conflicts

@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 26, 2026
@miquelsi

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miquelsi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@miquelsi: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-Azure-ARO-HCP-main-integration-e2e-parallel Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-integration-e2e-parallel-ocp-stable Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-integration-e2e-parallel-ocp-fast Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-integration-e2e-parallel-ocp-nightly Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-stage-e2e-parallel Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-stage-e2e-parallel-ocp-stable Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-stage-e2e-parallel-ocp-fast Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-stage-e2e-parallel-ocp-nightly Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-prod-e2e-parallel Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-prod-e2e-parallel-ocp-stable Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-prod-e2e-parallel-ocp-fast Azure/ARO-HCP presubmit Registry content changed
pull-ci-Azure-ARO-HCP-main-prod-e2e-parallel-ocp-nightly Azure/ARO-HCP presubmit Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-slow N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0 N/A periodic Periodic changed
periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-nightly N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-integration-e2e-parallel N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-stage-e2e-parallel N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-stage-e2e-parallel-slow N/A periodic Registry content changed
periodic-ci-Azure-ARO-HCP-main-periodic-stage-e2e-parallel-ocp-nightly N/A periodic Registry content changed
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse list to get an up-to-date list of affected jobs
Comment: /pj-rehearse abort to abort all active rehearsals
Comment: /pj-rehearse network-access-allowed to allow rehearsals of tests that have the restrict_network_access field set to false. This must be executed by an openshift org member who is not the PR author

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@miquelsi

Copy link
Copy Markdown
Contributor Author

/pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

@miquelsi: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci

openshift-ci Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

@miquelsi: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0 3621aba link unknown /pj-rehearse periodic-ci-Azure-ARO-HCP-main-periodic-prod-e2e-parallel-ocp-candidate-5-0

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Indicates a non-member PR verified by an org member that is safe to test.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants