Ephemeral Cluster Controller: Update mem requests and limits - #84061
Conversation
|
[REHEARSALNOTIFIER] Note: If this PR includes changes to step registry files ( |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited) Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review. WalkthroughThe ephemeral-cluster controller deployment now requests 2 GiB of memory and has a 6 GiB memory limit. ChangesEphemeral cluster resources
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a localized update to ephemeral cluster memory requests and limits, with no actionable merge-blocking risk remaining beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 15✅ Passed checks (15 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.) Full details: Stable And Deterministic Test NamesExplanation PASS: The pull request changes only Full details: Test Structure And QualityExplanation PASS: The pull request changes only memory request and limit values in clusters/app.ci/ephemeral-cluster/10_deployment.yaml. It adds or changes no Ginkgo test code, so the stated test-structure quality requirements do not apply. Full details: Microshift Test CompatibilityExplanation PASS: The pull request changes only memory requests and limits in Full details: Single Node Openshift (Sno) Test CompatibilityExplanation PASS: The pull request changes only memory request and limit values in Full details: Topology-Aware Scheduling CompatibilityExplanation PASS: The PR changes only the ephemeral-cluster controller memory request from 6Gi to 2Gi and memory limit from 16Gi to 6Gi. The Deployment retains its existing single replica and only the existing Full details: Ote Binary Stdout ContractExplanation The pull request changes only memory request and limit values in a Kubernetes Deployment YAML file. The complete commit diff contains no OTE binary code, suite setup, logging configuration, or stdout write. Therefore, it does not introduce a failure under the OTE Binary Stdout Contract. Full details: Ipv6 And Disconnected Network Test CompatibilityExplanation PASS: The pull request changes only memory values in Full details: No-Weak-CryptoExplanation PASS. The pull request changes only two Kubernetes memory values in Full details: Container-PrivilegesExplanation PASS: The pull request changes only the memory request from 6Gi to 2Gi and the memory limit from 16Gi to 6Gi in the Ephemeral Cluster Deployment. The parent-to-HEAD diff introduces no Full details: No-Sensitive-Data-In-LogsExplanation PASS: The pull request changes only the memory request and limit in the Deployment. The exact diff contains no logging, command-output, or sensitive-data changes. It does not introduce any stated sensitive-data-in-logs condition. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: danilo-gemoli, Prucek The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@danilo-gemoli: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
It has improved after #83982 has merged.
Summary by CodeRabbit