Skip to content

Ephemeral Cluster Controller: Update mem requests and limits - #84061

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
danilo-gemoli:chore/ecc/update-mem-limits
Aug 26, 2026
Merged

Ephemeral Cluster Controller: Update mem requests and limits#84061
openshift-merge-bot[bot] merged 1 commit into
openshift:mainfrom
danilo-gemoli:chore/ecc/update-mem-limits

Conversation

@danilo-gemoli

@danilo-gemoli danilo-gemoli commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

It has improved after #83982 has merged.

Summary by CodeRabbit

  • Reduced the Ephemeral Cluster Controller memory request from 6 GiB to 2 GiB.
  • Reduced the memory limit from 16 GiB to 6 GiB.
  • This lowers resource allocation for the OpenShift CI ephemeral-cluster infrastructure.

@openshift-merge-bot openshift-merge-bot Bot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 26, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@danilo-gemoli: no rehearsable tests are affected by this change

Note: If this PR includes changes to step registry files (ci-operator/step-registry/) and you expected jobs to be found, try rebasing your PR onto the base branch. This helps pj-rehearse accurately detect changes when the base branch has moved forward.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 00c10a99-499b-4ad7-80c8-a095761e4064

📥 Commits

Reviewing files that changed from the base of the PR and between ac548c8 and 6f7d740.

📒 Files selected for processing (1)
  • clusters/app.ci/ephemeral-cluster/10_deployment.yaml

Included review availability: Your plan provides up to 12 included reviews per hour; 11 remain after this review.


Walkthrough

The ephemeral-cluster controller deployment now requests 2 GiB of memory and has a 6 GiB memory limit.

Changes

Ephemeral cluster resources

Layer / File(s) Summary
Controller memory settings
clusters/app.ci/ephemeral-cluster/10_deployment.yaml
The controller memory request changed from 6Gi to 2Gi. The memory limit changed from 16Gi to 6Gi.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 6f7d7

This is a localized update to ephemeral cluster memory requests and limits, with no actionable merge-blocking risk remaining beyond normal checks and review.

Suggested reviewers: deepsm007

🚥 Pre-merge checks | ✅ 15
✅ Passed checks (15 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: updating memory requests and limits for the Ephemeral Cluster Controller.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PASS: The pull request changes only clusters/app.ci/ephemeral-cluster/10_deployment.yaml. The diff changes two static memory values (6Gi to 2Gi and 16Gi to 6Gi). It adds no Ginkgo test decla…
Test Structure And Quality ✅ Passed PASS: The pull request changes only memory request and limit values in clusters/app.ci/ephemeral-cluster/10_deployment.yaml. It adds or changes no Ginkgo test code, so the stated test-structure qualit…
Microshift Test Compatibility ✅ Passed PASS: The pull request changes only memory requests and limits in clusters/app.ci/ephemeral-cluster/10_deployment.yaml. The diff adds no Ginkgo e2e tests or test declarations, so the MicroShift test…
Single Node Openshift (Sno) Test Compatibility ✅ Passed PASS: The pull request changes only memory request and limit values in clusters/app.ci/ephemeral-cluster/10_deployment.yaml. It adds no Ginkgo tests or test bodies, so the SNO multi-node compatibili…
Topology-Aware Scheduling Compatibility ✅ Passed PASS: The PR changes only the ephemeral-cluster controller memory request from 6Gi to 2Gi and memory limit from 16Gi to 6Gi. The Deployment retains its existing single replica and only the existing `m…
Ote Binary Stdout Contract ✅ Passed The pull request changes only memory request and limit values in a Kubernetes Deployment YAML file. The complete commit diff contains no OTE binary code, suite setup, logging configuration, or stdout …
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PASS: The pull request changes only memory values in clusters/app.ci/ephemeral-cluster/10_deployment.yaml. The diff adds no Ginkgo e2e tests, IPv4 assumptions, or new external connectivity requireme…
No-Weak-Crypto ✅ Passed PASS. The pull request changes only two Kubernetes memory values in clusters/app.ci/ephemeral-cluster/10_deployment.yaml: the request changes from 6Gi to 2Gi, and the limit changes from 16Gi t…
Container-Privileges ✅ Passed PASS: The pull request changes only the memory request from 6Gi to 2Gi and the memory limit from 16Gi to 6Gi in the Ephemeral Cluster Deployment. The parent-to-HEAD diff introduces no `privileged: tru…
No-Sensitive-Data-In-Logs ✅ Passed PASS: The pull request changes only the memory request and limit in the Deployment. The exact diff contains no logging, command-output, or sensitive-data changes. It does not introduce any stated sens…
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Full details: Stable And Deterministic Test Names

Explanation

PASS: The pull request changes only clusters/app.ci/ephemeral-cluster/10_deployment.yaml. The diff changes two static memory values (6Gi to 2Gi and 16Gi to 6Gi). It adds no Ginkgo test declarations or test titles, so it cannot introduce dynamic or overly specific test names.

Full details: Test Structure And Quality

Explanation

PASS: The pull request changes only memory request and limit values in clusters/app.ci/ephemeral-cluster/10_deployment.yaml. It adds or changes no Ginkgo test code, so the stated test-structure quality requirements do not apply.

Full details: Microshift Test Compatibility

Explanation

PASS: The pull request changes only memory requests and limits in clusters/app.ci/ephemeral-cluster/10_deployment.yaml. The diff adds no Ginkgo e2e tests or test declarations, so the MicroShift test compatibility check does not apply.

Full details: Single Node Openshift (Sno) Test Compatibility

Explanation

PASS: The pull request changes only memory request and limit values in clusters/app.ci/ephemeral-cluster/10_deployment.yaml. It adds no Ginkgo tests or test bodies, so the SNO multi-node compatibility check is not applicable.

Full details: Topology-Aware Scheduling Compatibility

Explanation

PASS: The PR changes only the ephemeral-cluster controller memory request from 6Gi to 2Gi and memory limit from 16Gi to 6Gi. The Deployment retains its existing single replica and only the existing manual-provision toleration. It adds no anti-affinity, topology spread constraint, node selector or affinity, replica derivation, PDB, or control-plane/worker/arbiter scheduling rule. Therefore, the PR introduces no scheduling constraint covered by this check.

Full details: Ote Binary Stdout Contract

Explanation

The pull request changes only memory request and limit values in a Kubernetes Deployment YAML file. The complete commit diff contains no OTE binary code, suite setup, logging configuration, or stdout write. Therefore, it does not introduce a failure under the OTE Binary Stdout Contract.

Full details: Ipv6 And Disconnected Network Test Compatibility

Explanation

PASS: The pull request changes only memory values in clusters/app.ci/ephemeral-cluster/10_deployment.yaml. The diff adds no Ginkgo e2e tests, IPv4 assumptions, or new external connectivity requirements. The check is therefore not applicable.

Full details: No-Weak-Crypto

Explanation

PASS. The pull request changes only two Kubernetes memory values in clusters/app.ci/ephemeral-cluster/10_deployment.yaml: the request changes from 6Gi to 2Gi, and the limit changes from 16Gi to 6Gi. The diff introduces no MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB, custom crypto, or secret/token comparison code.

Full details: Container-Privileges

Explanation

PASS: The pull request changes only the memory request from 6Gi to 2Gi and the memory limit from 16Gi to 6Gi in the Ephemeral Cluster Deployment. The parent-to-HEAD diff introduces no privileged: true, hostPID, hostNetwork, hostIPC, SYS_ADMIN capability, root-user setting, or allowPrivilegeEscalation: true. The existing privilegedTenants command argument is unchanged and is not one of the specified manifest conditions.

Full details: No-Sensitive-Data-In-Logs

Explanation

PASS: The pull request changes only the memory request and limit in the Deployment. The exact diff contains no logging, command-output, or sensitive-data changes. It does not introduce any stated sensitive-data-in-logs condition.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 26, 2026
@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danilo-gemoli, Prucek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 26, 2026
@openshift-ci

openshift-ci Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

@danilo-gemoli: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 142f76e into openshift:main Aug 26, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants