Skip to content

TRT-2907: Add gcd platform to 5.1-main and 4.23-main views - #3939

Merged
openshift-merge-bot[bot] merged 4 commits into
openshift:mainfrom
openshift-trt:fix-TRT-2907
Aug 25, 2026
Merged

TRT-2907: Add gcd platform to 5.1-main and 4.23-main views#3939
openshift-merge-bot[bot] merged 4 commits into
openshift:mainfrom
openshift-trt:fix-TRT-2907

Conversation

@openshift-trt-agent

Copy link
Copy Markdown

Summary

  • Add gcd (Google Dedicated Cloud) platform to the 5.1-main and 4.23-main Component Readiness views in config/views.yaml
  • PR Gcd capability mapping #3899 added the GCD platform variant to the registry and to the 5.0-main and 4.22-main views, but missed the 5.1-main and 4.23-main views
  • This caused the warning "Unknown variant value: gcd (for variant Platform from view)" since GCD jobs exist for 5.0/5.1 releases but the views did not include the platform

Test plan

  • make lint passes
  • make test passes (all unit tests green)
  • make e2e passes (153/154 pass; 1 pre-existing failure in TestRegressionCacheLoader due to BigQuery credentials, unrelated to this change)
  • Verify warning no longer appears on the 5.0-main and 5.1-main Component Readiness views after deployment

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

PR openshift#3899 added the GCD (Google Dedicated Cloud) platform to the variant
registry and to the 5.0-main and 4.22-main views, but did not update the
5.1-main and 4.23-main views. This caused an "Unknown variant value: gcd
(for variant Platform from view)" warning in Component Readiness because
the variant validation found gcd platform data from GCD jobs running in
5.0/5.1 releases that was not recognized by these views.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification
This repo is configured to use the pipeline controller. Second-stage tests will be triggered either automatically or after lgtm label is added, depending on the repository configuration. The pipeline controller will automatically detect which contexts are required and will utilize /test Prow commands to trigger the second stage.

For optional jobs, comment /test ? to see a list of all defined jobs. To trigger manually all jobs from second stage use /pipeline required command.

This repository is configured in: automatic mode

@openshift-ci openshift-ci Bot added the ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review label Aug 24, 2026
@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Aug 24, 2026
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 24, 2026
@openshift-ci-robot

openshift-ci-robot commented Aug 24, 2026

Copy link
Copy Markdown

@openshift-trt-agent[bot]: This pull request references TRT-2907 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set.

Details

In response to this:

Summary

  • Add gcd (Google Dedicated Cloud) platform to the 5.1-main and 4.23-main Component Readiness views in config/views.yaml
  • PR Gcd capability mapping #3899 added the GCD platform variant to the registry and to the 5.0-main and 4.22-main views, but missed the 5.1-main and 4.23-main views
  • This caused the warning "Unknown variant value: gcd (for variant Platform from view)" since GCD jobs exist for 5.0/5.1 releases but the views did not include the platform

Test plan

  • make lint passes
  • make test passes (all unit tests green)
  • make e2e passes (153/154 pass; 1 pre-existing failure in TestRegressionCacheLoader due to BigQuery credentials, unrelated to this change)
  • Verify warning no longer appears on the 5.0-main and 5.1-main Component Readiness views after deployment

Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 24, 2026
@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Hi @openshift-trt-agent[bot]. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@neisw

neisw commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

add a unit test for the periodic-ci-openshift-release-main-ci-5.0-e2e-gcd-ovn in https://github.com/openshift-trt/sippy/blob/4d84967ac50db09ae6ebf7451e2c9cbcf41e17fe/pkg/variantregistry/ocp_test.go#L23 the platform should be gcd and the release 5.0

Add test case for periodic-ci-openshift-release-main-ci-5.0-e2e-gcd-ovn
to verify platform is correctly identified as gcd with release 5.0.
Also update variant snapshot to fix pre-existing gcd JobTier mismatch.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-trt-agent

Copy link
Copy Markdown
Author

Done. Added test case for periodic-ci-openshift-release-main-ci-5.0-e2e-gcd-ovn verifying platform=gcd and release=5.0, along with the component/capability variants (Installer/GCPSovereignCloudInstall). Also updated the variant snapshot to fix a pre-existing gcd JobTier mismatch (candidate -> standard).


AI-assisted response via Claude Code

@neisw

neisw commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

I believe we need to add a case for gcd platform to skip using the value from the cluster

@neisw

neisw commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

convert this from draft to a pr

GCD (Google Dedicated Cloud) jobs report their platform as GCP in
cluster data, but we want to keep gcd in its own separate bucket.
Add gcd to the platform skip list alongside rosa and osd-gcp.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-trt-agent
openshift-trt-agent Bot marked this pull request as ready for review August 25, 2026 12:00
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 25, 2026
@openshift-trt-agent

Copy link
Copy Markdown
Author

Done. Added gcd to the platform skip list in CalculateVariantsForJob so cluster data doesn't override the job-name-derived gcd platform with gcp, matching the existing pattern for rosa and osd-gcp.


AI-assisted response via Claude Code

@openshift-trt-agent

Copy link
Copy Markdown
Author

Done. Converted from draft to ready for review.


AI-assisted response via Claude Code

@openshift-ci
openshift-ci Bot requested review from mstaeble and sosiouxme August 25, 2026 12:04
@neisw

neisw commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@openshift-ci openshift-ci Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 25, 2026
@neisw

neisw commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

update the new test to pass in a variants file the specified the gcp platform similar to https://github.com/openshift-trt/sippy/blob/f82b6591bea13949cc7618fcb3c2459fff3b56dd/pkg/variantregistry/ocp_test.go#L156

Verify that cluster data reporting gcp platform does not override the
gcd platform derived from the job name.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@openshift-trt-agent

Copy link
Copy Markdown
Author

Done. Added variantsFile with "Platform": "gcp" to the GCD test case, verifying that cluster data reporting gcp does not override the gcd platform derived from the job name.


AI-assisted response via Claude Code

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling required tests:
/test e2e

@openshift-trt-agent

Copy link
Copy Markdown
Author

CI failure (not fixing): ci/prow/e2e

Classification: pre_existing

Evidence: The e2e job (link) fails with 4 test failures in test/e2e/componentreadiness/triage: Test_TriageAPI/get_with_expanded_regressions and Test_TriagePotentialMatchingRegressions/find_potential_matching_regressions. This PR changes only config/views.yaml, pkg/variantregistry/ocp.go, pkg/variantregistry/ocp_test.go, and pkg/variantregistry/snapshot.yaml, none of which affect the failing triage e2e tests (which use config/seed-views.yaml). The identical 4 failures appear on unrelated open PRs #3942 and #3944, confirming this is a fleet-wide pre-existing issue.

Action needed: Human or infra follow-up required — not addressed in this PR.


AI-assisted response via Claude Code

@neisw

neisw commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/test e2e

1 similar comment
@neisw

neisw commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/test e2e

@neisw

neisw commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/test e2e

@neisw

neisw commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 25, 2026
@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: neisw, openshift-trt-agent[bot]

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 25, 2026
@openshift-ci

openshift-ci Bot commented Aug 25, 2026

Copy link
Copy Markdown
Contributor

@openshift-trt-agent: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit c80c66b into openshift:main Aug 25, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. ready-for-human-review Indicates a PR has been reviewed by automated tools and is ready for human review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants