TRT-2907: Add gcd platform to 5.1-main and 4.23-main views - #3939
Conversation
PR openshift#3899 added the GCD (Google Dedicated Cloud) platform to the variant registry and to the 5.0-main and 4.22-main views, but did not update the 5.1-main and 4.23-main views. This caused an "Unknown variant value: gcd (for variant Platform from view)" warning in Component Readiness because the variant validation found gcd platform data from GCD jobs running in 5.0/5.1 releases that was not recognized by these views. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Pipeline controller notification For optional jobs, comment This repository is configured in: automatic mode |
|
@openshift-trt-agent[bot]: This pull request references TRT-2907 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "5.1.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Hi @openshift-trt-agent[bot]. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
add a unit test for the |
Add test case for periodic-ci-openshift-release-main-ci-5.0-e2e-gcd-ovn to verify platform is correctly identified as gcd with release 5.0. Also update variant snapshot to fix pre-existing gcd JobTier mismatch. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Done. Added test case for AI-assisted response via Claude Code |
|
I believe we need to add a case for gcd platform to skip using the value from the cluster |
|
convert this from draft to a pr |
GCD (Google Dedicated Cloud) jobs report their platform as GCP in cluster data, but we want to keep gcd in its own separate bucket. Add gcd to the platform skip list alongside rosa and osd-gcp. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Done. Added AI-assisted response via Claude Code |
|
Done. Converted from draft to ready for review. AI-assisted response via Claude Code |
|
/ok-to-test |
|
update the new test to pass in a variants file the specified the |
Verify that cluster data reporting gcp platform does not override the gcd platform derived from the job name. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
Done. Added AI-assisted response via Claude Code |
|
Scheduling required tests: |
|
CI failure (not fixing): ci/prow/e2e Classification: pre_existing Evidence: The e2e job (link) fails with 4 test failures in Action needed: Human or infra follow-up required — not addressed in this PR. AI-assisted response via Claude Code |
|
/test e2e |
1 similar comment
|
/test e2e |
|
/test e2e |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: neisw, openshift-trt-agent[bot] The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@openshift-trt-agent: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Summary
gcd(Google Dedicated Cloud) platform to the5.1-mainand4.23-mainComponent Readiness views inconfig/views.yaml5.0-mainand4.22-mainviews, but missed the5.1-mainand4.23-mainviewsTest plan
make lintpassesmake testpasses (all unit tests green)make e2epasses (153/154 pass; 1 pre-existing failure inTestRegressionCacheLoaderdue to BigQuery credentials, unrelated to this change)Always review AI generated responses prior to use.
Generated with Claude Code via openshift-developer plugin