Skip to content

[edpm_deploy_baremetal] Wait for ProvisionServer localImageUrl - #4136

Open
rebtoor wants to merge 1 commit into
openstack-k8s-operators:mainfrom
rebtoor:fix/edpm-deploy-baremetal-wait-local-image-url
Open

[edpm_deploy_baremetal] Wait for ProvisionServer localImageUrl#4136
rebtoor wants to merge 1 commit into
openstack-k8s-operators:mainfrom
rebtoor:fix/edpm-deploy-baremetal-wait-local-image-url

Conversation

@rebtoor

@rebtoor rebtoor commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Retry fetching OpenStackProvisionServer until status.localImageUrl is set.
  • Use safe .get() access when deriving the checksum URL fallback.
  • Store the image URL in a fact for the subsequent HTTP probes.

Problem

cifmw-crc-podified-edpm-baremetal-bootc failed in edpm_deploy_baremetal
with 'dict object' has no attribute 'localImageUrl' even though the
Provision Server pod and deployment were ready. The operator publishes
localImageUrl after reconciliation, not when the Deployment becomes
Available.

Test plan

  • Re-run cifmw-crc-podified-edpm-baremetal-bootc on rdoproject Zuul
  • TEST_SINGLE_ROLE=edpm_deploy_baremetal make molecule (dry-run converge)

Depends-On: #4130

Made with Cursor

@openshift-ci

openshift-ci Bot commented Aug 24, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign dasm for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

The role queried OpenStackProvisionServer status as soon as the
deployment was Available, but the baremetal operator sets
status.localImageUrl asynchronously. Retry k8s_info until the URL is
present and use dict.get() when building checksum fallback facts.

Seen in cifmw-crc-podified-edpm-baremetal-bootc while validating
ci-framework#4131 (unrelated failure).

Assisted-By: Cursor
Co-authored-by: Cursor <cursoragent@cursor.com>
Signed-off-by: Roberto Alfieri <ralfieri@redhat.com>
@rebtoor
rebtoor force-pushed the fix/edpm-deploy-baremetal-wait-local-image-url branch from 775b98b to 896aff8 Compare August 24, 2026 09:01

@abays abays left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@centosinfra-prod-github-app

Copy link
Copy Markdown

Build failed (check pipeline). Post recheck (without leading slash)
to rerun all jobs. Make sure the failure cause has been resolved before
you rerun jobs.

https://gateway-cloud-softwarefactory.apps.ocp.cloud.ci.centos.org/zuul/t/rdoproject.org/buildset/4c7f7278c9814b5eb8b0acc74e22371a

✔️ openstack-k8s-operators-content-provider SUCCESS in 3h 13m 54s
podified-multinode-edpm-deployment-crc FAILURE in 2h 01m 36s
cifmw-crc-podified-edpm-baremetal FAILURE in 2h 05m 59s
cifmw-crc-podified-edpm-baremetal-minor-update FAILURE in 1h 55m 06s
✔️ cifmw-pod-zuul-files SUCCESS in 5m 27s
✔️ openstack-k8s-operators-content-provider-bootc SUCCESS in 3h 11m 14s
cifmw-crc-podified-edpm-baremetal-bootc FAILURE in 1h 58m 45s
✔️ noop SUCCESS in 0s
✔️ cifmw-pod-ansible-test SUCCESS in 9m 56s
✔️ cifmw-pod-pre-commit SUCCESS in 9m 55s
✔️ cifmw-molecule-edpm_deploy_baremetal SUCCESS in 5m 10s

@nemarjan

Copy link
Copy Markdown
Contributor

recheck

@centosinfra-prod-github-app

Copy link
Copy Markdown

This change depends on a change that failed to merge.

Change #4130 is needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants