CORE-2710: Compose render-callback style in react-aria-components wrappers

[OpenStaxClaude]

Jira: CORE-2710

The style half of the bug fixed for className in CORE-2708 / #136.

Problem

react-aria-components types style on anything extending StyleRenderProps as CSSProperties | ((values) => CSSProperties). Three wrappers merged the caller's style into their own CSS-variable object with a spread:

const popoverStyle: CSSPropertiesWithVariables = {
  '--navbar-popover-border-color': colors.palette.darkGreen,
  ...style   // <-- if style is a function, this contributes nothing
};

Spreading a function into an object literal is legal TypeScript and copies no enumerable own properties, so a caller-supplied style callback was silently discarded. Unlike the className case there was no type error to catch it.

Fix

NavBarMenuItem, NavBarPopover and TreeCheckbox now build their CSS variables inside a composeRenderProps callback, which resolves the callback form before the merge:

const popoverStyle = composeRenderProps(
  style,
  (resolvedStyle): CSSPropertiesWithVariables => ({
    '--navbar-popover-border-color': colors.palette.darkGreen,
    ...resolvedStyle
  })
);

The caller still spreads last, so its ability to override the wrapper's CSS variables is preserved.

TreeCheckbox also drops its as unknown as RACCheckboxProps['style'] double cast in favour of a CSSPropertiesWithVariables return-type annotation, which types the custom properties properly rather than casting them away.

Acceptance criteria

• The three components merge a render-callback style instead of discarding it.
• The object form is unchanged, including caller-last precedence over the wrapper's variables.
• Each component has a callback-style test, plus an override test and an object-form test. Confirmed failing before the fix: stashing only the two source files leaves 6 failed, 11 passed across the two specs — the 6 callback/override cases fail, the object-form cases pass.
• No snapshot churn. All 116 snapshots pass untouched; the emitted inline styles for the object form are byte-identical (RAC's useRenderProps resolves both forms to the same object, and none of MenuItem/Popover/Checkbox supply a defaultStyle).

Notes

• Branched from main, not from CORE-2708: Compose render-callback classNames in react-aria-components wrappers #136, so it stands alone. Both PRs touch NavBarMenuButtons.tsx and TreeCheckbox.tsx on adjacent lines (className= vs style=), so whichever merges second will want a small rebase.
• The second commit here is a cherry-pick of a15d901 from CORE-2708: Compose render-callback classNames in react-aria-components wrappers #136 (JiraEmail/JiraToken → JIRA_EMAIL/JIRA_TOKEN). The Jira check fails on any branch cut from main without it — it did on this PR's first two runs, exactly as it did on CORE-2708: Compose render-callback classNames in react-aria-components wrappers #136 before that commit. Since it's byte-identical to the commit on CORE-2708: Compose render-callback classNames in react-aria-components wrappers #136, whichever lands first the other merges cleanly.
• While running the suite repeatedly I saw ProfileMenu › opens menu on click fail its document.body snapshot twice on a cold jest cache, with a stray data-pressed="true" in the received output. It passed on 11 consecutive runs afterwards and does not involve style. Looks like a pre-existing press-state timing flake rather than anything from this change — flagging it in case CI hits it.

[Copilot]

Pull request overview

Fixes render-callback style handling in React Aria component wrappers while preserving caller override precedence.

Changes:

• Composes callback and object styles for three wrappers.
• Adds regression and override-precedence tests.
• Corrects Jira secret references and documents the fix.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/components/Tree/TreeCheckbox.tsx	Composes checkbox styles safely.
src/components/Tree/TreeCheckbox.spec.tsx	Tests callback and object styles.
src/components/NavBarMenuButtons.tsx	Composes menu item and popover styles.
src/components/NavBarMenuButtons.spec.tsx	Adds style regression tests.
CHANGELOG.md	Documents the corrected behavior.
.github/workflows/checks.yml	Corrects Jira secret names.

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.