Skip to content

feat(extension-manager): add manager composition and public API - #390

Open
gene9831 wants to merge 18 commits into
opentiny:developfrom
gene9831:codex/pr2-extension-manager
Open

feat(extension-manager): add manager composition and public API#390
gene9831 wants to merge 18 commits into
opentiny:developfrom
gene9831:codex/pr2-extension-manager

Conversation

@gene9831

@gene9831 gene9831 commented Aug 18, 2026

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • New Features

    • Added the Extension Manager component with tabbed navigation, filtering, searchable extension lists, collapsible sections, empty states, and customizable slots.
    • Added keyboard navigation for tabs, including arrow keys, Home, End, Enter, and Space.
    • Added tag and case-insensitive search filtering with per-tab filter state.
    • Added installable namespace support for the Extension Manager, Card, and Card Grid components.
  • Tests

    • Added comprehensive coverage for filtering, navigation, section behavior, events, responsive layouts, and component registration.

@coderabbitai

coderabbitai Bot commented Aug 18, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: af47bd33-bdc1-4e4c-843e-951b7bcb4a16

📥 Commits

Reviewing files that changed from the base of the PR and between 8968b22 and 68b11c7.

📒 Files selected for processing (18)
  • packages/components/src/extension-manager/components/ExtensionFilterControls.vue
  • packages/components/src/extension-manager/components/ExtensionManagerSection.types.ts
  • packages/components/src/extension-manager/components/ExtensionManagerSection.vue
  • packages/components/src/extension-manager/components/ExtensionManagerTabs.vue
  • packages/components/src/extension-manager/composables/useExtensionManagerFilterState.ts
  • packages/components/src/extension-manager/composables/useExtensionManagerState.ts
  • packages/components/src/extension-manager/composables/useFilter.ts
  • packages/components/src/extension-manager/filter.type.ts
  • packages/components/src/extension-manager/index.ts
  • packages/components/src/extension-manager/index.type.test.ts
  • packages/components/src/extension-manager/index.vue
  • packages/components/src/extension-manager/public.type.ts
  • packages/components/src/index.ts
  • packages/test/component/extension-manager/ExtensionManager.fixture.vue
  • packages/test/component/extension-manager/ExtensionManager.spec.ts
  • packages/test/component/extension-manager/ExtensionManagerNamespace.fixture.vue
  • packages/test/component/extension-manager/ExtensionManagerNamespace.spec.ts
  • packages/test/component/extension-manager/ExtensionManagerUncontrolled.fixture.vue

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

Adds the ExtensionManager Vue component with tabs, filtering, collapsible installed and available sections, controlled and uncontrolled state, event forwarding, public exports, type validation, and Playwright component coverage.

Changes

Extension manager

Layer / File(s) Summary
Filter contracts and controls
packages/components/src/extension-manager/filter.type.ts, packages/components/src/extension-manager/composables/useFilter.ts, packages/components/src/extension-manager/composables/useExtensionManagerFilterState.ts, packages/components/src/extension-manager/components/ExtensionFilterControls.vue
Adds filter state types, per-tab persistence, tag normalization, search filtering, filter controls, and responsive styling.
Tab and section state
packages/components/src/extension-manager/composables/useExtensionManagerState.ts, packages/components/src/extension-manager/components/ExtensionManagerTabs.vue
Adds controlled and uncontrolled tab selection, keyboard navigation, active-tab indicators, section expansion state, and state cleanup.
Section rendering
packages/components/src/extension-manager/components/ExtensionManagerSection.types.ts, packages/components/src/extension-manager/components/ExtensionManagerSection.vue
Adds collapsible installed and available sections with card-grid, empty-state, slot, and event forwarding support.
Manager integration and tests
packages/components/src/extension-manager/index.vue, packages/test/component/extension-manager/*
Composes tabs, filters, sections, slots, item partitioning, event routing, and fixture-driven component tests.
Public API and type validation
packages/components/src/extension-manager/index.ts, packages/components/src/extension-manager/public.type.ts, packages/components/src/index.ts, packages/components/src/extension-manager/index.type.test.ts
Exports and registers ExtensionManager, exposes the component namespace and public types, and validates the component type surface.

Estimated code review effort: 4 (Complex) | ~60 minutes

Merge Risk: ⚪ Minimal · up to 68b11

This PR adds a browser-side extension-management component and public API without changing services, permissions, persistence, or deployment behavior. No actionable merge-blocking risk remains beyond normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant Parent
  participant ExtensionManager
  participant useExtensionManagerState
  participant useFilter
  participant ExtensionManagerSection

  Parent->>ExtensionManager: provide tabs and active tab
  ExtensionManager->>useExtensionManagerState: initialize tab and section state
  ExtensionManager->>useFilter: provide active-tab items and filter state
  useFilter-->>ExtensionManager: return filtered items and controls
  ExtensionManager->>ExtensionManagerSection: render installed and available items
  ExtensionManagerSection-->>ExtensionManager: emit action or section-toggle
  ExtensionManager-->>Parent: emit manager event
Loading

Poem

I hop through tabs where extensions grow
Filters trim the rows in a tidy flow
Sections fold and open with care
Cards send their events through the air
The manager now bounds the whole affair

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes: adding ExtensionManager composition and exposing its public API. It is concise and specific.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 11 files. (7 skipped: 7 unsupported.)

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

✅ Preview build completed successfully!

Click the image above to preview.
Preview will be automatically removed when this PR is closed.

@github-actions

github-actions Bot commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant