Fix make sure key is defined before comparing it. - #3161
Merged
Conversation
Make sure `$localData->{set_id}` is defined before comparing
it in a `ne` comparision in still_no_right achievement.
somiaj
force-pushed
the
more-achievement-fixes
branch
from
August 20, 2026 22:29
4d74a41 to
22e8209
Compare
drgrice1
approved these changes
Aug 20, 2026
|
|
||
| # Initialize $localData. | ||
| $localData->{incorrect_streak} //= 0; | ||
| $localData->{set_id} //= ''; |
Member
There was a problem hiding this comment.
You could also change line 18 below to
if ($problem->set_id ne ($localData->{set_id} // '').
But this works too. Either way is fine. Just noting.
Alex-Jordan
approved these changes
Aug 20, 2026
Alex-Jordan
added a commit
that referenced
this pull request
Aug 20, 2026
Fix make sure key is defined before comparing it. (Hotfix of #3161)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure
$localData->{set_id}is defined before comparing it in anecomparison in still_no_right achievement.Found another achievement that compared a value that could be undefined.