Test time announce icon - #3165
Conversation
29cd1eb to
f713bea
Compare
|
@drgrice1 is there a way to format a single file, vs |
f713bea to
e23b6e5
Compare
|
I use the formatter in vim via the coc.nvim coc-prettier extension. |
|
Maybe it is time that we stop using Font Awesome, and switch to using Bootstrap icons. Then we can use their |
|
I am using bootstrap icons here, but I copied the svg code for them, not just the |
|
The Font Awesome icons go well with Bootstrap also. In fact, historically, the Font Awesome icon set was created for usage with Bootstrap. |
|
Just one quick thing until I can test for real. Could there be more space between the text and the button? |
|
I thought the same thing. |
e23b6e5 to
4abcc66
Compare
|
I'd go more. Also, should it be margin at the beginning of the button, rather than margin at the end of the text? Does removing the p-1 make the button too small? Asking because presently the button seems large up against the yellowish behind it. I'm not looking at a live build though. Last nitpick. The icon in the button does not appear to be centered. I see it as slightly to the right of center, as if there is some extra padding to its left. |
Place a small button with a speaker icon next to the remaining time on tests instead of a full button on the second row. This makes the remaining time + button overlay take up less space.
4abcc66 to
9273c87
Compare



Place a small button with a speaker icon next to the remaining time on tests instead of a full button on the second row. This makes the remaining time + button overlay take up less space.
I went with using a "sound wave" icon, but am open to what ever icon is preferred. Here is what the remaining time overlay looks like with this:
I originally tried a megaphone, but the bootstrap one didn't look right to me (maybe a megaphone with some sound waves coming from it would be useful). Here is what the megaphone looks like.
@Alex-Jordan any thoughts? Also is
aria-labelenough to make this accessible?