comrade: update to 0.2.1 - #30497
Conversation
25d89fc to
1fe1e99
Compare
openwrt-ai
left a comment
openwrt-ai
left a comment
There was a problem hiding this comment.
Commit checks
1fe1e99"comrade: update to 0.2.1" — the body lists only the upstream change log; the new arch-conditionallibatomicdependency is an undocumented packaging change. Add a line saying why it was added.
Generated by Claude Code
| TITLE:=Serverless peer-to-peer terminal sharing | ||
| URL:=https://github.com/dangowrt/comrade | ||
| DEPENDS:=+libssh +libjuice +libdht +libkcp +libmonocypher +libpthread | ||
| DEPENDS:=+(mips||mipsel||powerpc):libatomic +libssh +libjuice +libdht \ |
There was a problem hiding this comment.
arm/armeb are missing from this list, and Test arm_cortex-a15_neon-vfpv4 failed in this run alongside the mips/mipsel/powerpc jobs. Both in-tree precedents for a 64-bit-atomics dependency list them — net/samba4/Makefile:66 and multimedia/gstreamer1/Makefile:104 use +(arm||armeb||mips||mipsel||powerpc):libatomic, and lang/ruby/Makefile:225 adds arc. Against that, arm_cortex-a9_vfpv3-d16 passed, so CI alone doesn't settle it — is arm deliberately excluded?
Generated by Claude Code
| URL:=https://github.com/dangowrt/comrade | ||
| DEPENDS:=+libssh +libjuice +libdht +libkcp +libmonocypher +libpthread | ||
| DEPENDS:=+(mips||mipsel||powerpc):libatomic +libssh +libjuice +libdht \ | ||
| +libkcp +libmonocypher +libpthread |
There was a problem hiding this comment.
Package/comrade-tests builds from the same sources but its DEPENDS at net/comrade/Makefile:76 did not get the same libatomic entry, which looks like what fails the mips/mipsel/powerpc builds:
Full file listing:
-rw-r--r-- 1 runner runner 120545 Sep 10 04:32 comrade-0.2.1-r1.apk
...
##[error]Process completed with exit code 2.
comrade packaged fine on mips_24kc and no comrade-tests apk was produced — consistent with the missing-library-dependency check tripping on libatomic.so.1; same on mipsel_24kc, powerpc_464fp and powerpc_8548.
Generated by Claude Code
There was a problem hiding this comment.
|
|
||
| PKG_NAME:=comrade | ||
| PKG_VERSION:=0.1.17 | ||
| PKG_VERSION:=0.2.1 |
There was a problem hiding this comment.
The comment on lines 31-32 states that STUN_LIST_VERSION is pinned to the commit v$(PKG_VERSION)'s own deps/always-online-stun points at, but it stays at 4dc3b52 across 0.1.17 → 0.2.1. Does v0.2.1 still point at that commit, or should the pin and its hash move with the version?
Generated by Claude Code
Upstream changes: dangowrt/comrade@v0.1.17...v0.2.1 Signed-off-by: Daniel Golle <daniel@makrotopia.org>
1fe1e99 to
77fe453
Compare
2 participants
📦 Package Details
Maintainer: @dangowrt
Description:
Update net/comrade to 0.2.1.
v0.2.0
ended
route
text
shadow
reach
us
end that cannot reach it
climbs
came
state
found
are locked
the tool
freed
it
engage
it
v0.2.1
🧪 Run Testing Details
✅ Formalities