feat: add --conversation-id to chat and CONVERSATION_NOT_FOUND error … - #34
Merged
Conversation
…code Support continuing existing AI conversations via --conversation-id/-c flag, and surface expired/missing conversations with a dedicated error code.
mateuszk-opera
force-pushed
the
feat/conversation-id-in-chat
branch
from
September 1, 2026 11:37
5f1d776 to
d40e603
Compare
macieju-opera
approved these changes
Sep 1, 2026
macieju-opera
left a comment
macieju-opera
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Clean implementation with good backward-compat handling.
--conversation-id/-cflag parsing is correct, including the=syntax error message- JSON response parsing with fallback to raw text handles the transition period well
- Shape validation guards against malformed responses from the extension
- Exit code 2 for
CONVERSATION_NOT_FOUNDis consistent withNOT_FOUND - Test coverage is thorough — new parseChatArgs cases, JSON shape validation, and exit code table
One minor observation (not blocking): the isValidShape type guard in the test file duplicates the inline check in handleChat. If the production shape ever changes, the test guard would need a manual update. A shared helper would be cleaner, but it's fine as-is given the test is covering the contract from both sides.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…code
Support continuing existing AI conversations via --conversation-id/-c flag, and surface expired/missing conversations with a dedicated error code.