Sync Python gRPC stubs from dp-grpc - #49
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Critical Ruff configuration and grpcio dependency mismatches block approval.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Automated sync of generated Python gRPC stubs for release 1.16.0.
Changes:
- Updates five generated stubs to require
grpcio1.84.0. - Sets Ruff’s target version to invalid value
1.16.0. - Leaves the declared
grpciominimum at1.83.1.
File summaries
| File | Summary |
|---|---|
src/dp_python_lib/grpc/query_pb2_grpc.py |
Generated stub requires grpcio 1.84.0, but dependency floor remains 1.83.1. Critical (3 votes). |
src/dp_python_lib/grpc/ingestion_stream_pb2_grpc.py |
Generated stub requires grpcio 1.84.0, but dependency floor remains 1.83.1. Critical (1 vote). |
src/dp_python_lib/grpc/ingestion_pb2_grpc.py |
Generated stub requires grpcio 1.84.0, but dependency floor remains 1.83.1. Critical (1 vote). |
src/dp_python_lib/grpc/common_pb2_grpc.py |
Generated stub requires grpcio 1.84.0, but dependency floor remains 1.83.1. Critical (1 vote). |
src/dp_python_lib/grpc/annotation_pb2_grpc.py |
Generated stub requires grpcio 1.84.0, but dependency floor remains 1.83.1. Critical (1 vote). |
pyproject.toml |
Ruff target version is invalid and the grpcio dependency minimum needs alignment. Critical (3 votes). |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 6
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| from . import annotation_pb2 as annotation__pb2 | ||
|
|
||
| GRPC_GENERATED_VERSION = '1.83.1' | ||
| GRPC_GENERATED_VERSION = '1.84.0' |
|
|
||
|
|
||
| GRPC_GENERATED_VERSION = '1.83.1' | ||
| GRPC_GENERATED_VERSION = '1.84.0' |
| from . import ingestion_pb2 as ingestion__pb2 | ||
|
|
||
| GRPC_GENERATED_VERSION = '1.83.1' | ||
| GRPC_GENERATED_VERSION = '1.84.0' |
| from . import ingestion_stream_pb2 as ingestion__stream__pb2 | ||
|
|
||
| GRPC_GENERATED_VERSION = '1.83.1' | ||
| GRPC_GENERATED_VERSION = '1.84.0' |
| from . import query_pb2 as query__pb2 | ||
|
|
||
| GRPC_GENERATED_VERSION = '1.83.1' | ||
| GRPC_GENERATED_VERSION = '1.84.0' |
… stubs The stub sync workflow in dp-grpc rewrote ruff's `target-version` setting. Its "Update pyproject.toml version" step substitutes on an unanchored `version\s*=\s*"[^"]+"`, which matches the tail of `target-version = "py310"` and replaced it with `target-version = "1.16.0"`. Ruff cannot parse that as a Python dialect, so it exited 2 before linting anything and failed CI with `unknown variant `1.16.0``. Restore `py310`. The workflow step is itself obsolete -- this project takes its version from the git tag via setuptools-scm (`dynamic = ["version"]`), so there is no literal `version = "..."` for it to bump and ruff's key is the only line it can match. Removing the step is handled separately in dp-grpc. Also raise both grpcio floors from 1.83.1 to 1.84.0. The regenerated stubs set `GRPC_GENERATED_VERSION = '1.84.0'` and raise at import time on anything older: RuntimeError: The grpc package installed is at version 1.83.1, but the generated code in annotation_pb2_grpc.py depends on grpcio>=1.84.0. CI did not catch this because a fresh install resolves `grpcio>=1.83.1` to the newest release, but any environment already pinned at 1.83.1 fails on import, and the published wheel's metadata would understate what it actually needs. The `[codegen]` floor moves with it, since 1.84.0 stubs come from 1.84.0 tooling. protobuf is unchanged: the stubs still validate against 7.35. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0151QFCHYMNBgEVNGLTgsoFL
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync of generated Python gRPC stubs from dp-grpc.
Release: true
Version: 1.16.0
Source run: https://github.com/osprey-dcs/dp-grpc/actions/runs/35118701660