Conversation
|
Hi @nickzema, I'm getting a 404 error for |
accidentally had /docs. Corrected. https://raw.githubusercontent.com/nickzema/osesheet/main/ose-character-sheet/store.md
|
Sorry about that, it's the wrong address. |
| "loot-tables": "https://raw.githubusercontent.com/thp21000/loot-tables-for-OBR/main/public/store.md", | ||
| "dragonbane-sheet": "https://nboughton.uk/apps/obr-dragonbane-sheet/store.md" | ||
| "dragonbane-sheet": "https://nboughton.uk/apps/obr-dragonbane-sheet/store.md", | ||
| "ose-character-sheets": "https://raw.githubusercontent.com/nickzema/osesheet/main/ose-character-sheet/store.md" |
There was a problem hiding this comment.
|
Hi @nickzema, The revised store.md URL you commented above is working, but you need that to be in the PR itself, for which you might need to close this one and raise a new PR with the correct details (I don't think you can edit a PR after the fact). A preliminary run of the 1st-stage verification failed only on the tags field: Apart from the PR needing to be changed and the store's tags issue, the rest of the validation passed, so I'm happy to re-run all of that once you've resolved these. Also, it's not a showstopper, but it's best practice to handle context-menu items through a background script (entry point: |
Make sure that your submission has the following:
https://raw.githubusercontent.com/nickzema/ose-character-sheet/main/docs/store.md
Please, go through these steps before you submit a PR.
You have done your changes in a separate branch.
You have a descriptive commit message with a short title (first line).
You have only one commit (if not, squash them into one commit).
Your pull request MUST target the
mainbranch on this repository.Your pull request puts your extensions details as the last entry in the extensions.json file