Skip to content

Add Old-School Essentials (OSE) Character Sheets extension - #177

Open
nickzema wants to merge 3 commits into
owlbear-rodeo:mainfrom
nickzema:main
Open

nickzema wants to merge 3 commits into
owlbear-rodeo:mainfrom
nickzema:main

Conversation

@nickzema

Copy link
Copy Markdown

Make sure that your submission has the following:

  • A link to the raw github markdown file with a YAML front matter definition containing:
    • The title of your extension
    • A description of your extension
    • The author
    • A hero image
    • An icon
    • Tags (these will help with your extension's discoverability)
    • A link to your extensions manifest

https://raw.githubusercontent.com/nickzema/ose-character-sheet/main/docs/store.md

Please, go through these steps before you submit a PR.

  • You have done your changes in a separate branch.

  • You have a descriptive commit message with a short title (first line).

  • You have only one commit (if not, squash them into one commit).

  • Your pull request MUST target the main branch on this repository.

  • Your pull request puts your extensions details as the last entry in the extensions.json file

@Several-Record7234

Copy link
Copy Markdown
Collaborator

Hi @nickzema, I'm getting a 404 error for https://raw.githubusercontent.com/nickzema/ose-character-sheet/main/docs/store.md and I see that your repo appears to be at https://github.com/nickzema/osesheet/tree/main/ose-character-sheet, so please could you correct that and let me know? When that's done I'll run 1st-stage verification for you.

@nickzema

nickzema commented Sep 24, 2026 •

Copy link
Copy Markdown
Author

Sorry about that, it's the wrong address.
https://raw.githubusercontent.com/nickzema/ose-character-sheet/main/docs/store.md

@nickzema nickzema left a comment

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread extensions.json
"loot-tables": "https://raw.githubusercontent.com/thp21000/loot-tables-for-OBR/main/public/store.md",
"dragonbane-sheet": "https://nboughton.uk/apps/obr-dragonbane-sheet/store.md"
"dragonbane-sheet": "https://nboughton.uk/apps/obr-dragonbane-sheet/store.md",
"ose-character-sheets": "https://raw.githubusercontent.com/nickzema/osesheet/main/ose-character-sheet/store.md"

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Several-Record7234

Several-Record7234 commented Sep 28, 2026 •

Copy link
Copy Markdown
Collaborator

Hi @nickzema,

The revised store.md URL you commented above is working, but you need that to be in the PR itself, for which you might need to close this one and raise a new PR with the correct details (I don't think you can edit a PR after the fact).

A preliminary run of the 1st-stage verification failed only on the tags field: "tags" must be one of [dice, fog, tool, content-pack, drawing, audio, combat, automation, other], so please edit your store.md file to comply.

Apart from the PR needing to be changed and the store's tags issue, the rest of the validation passed, so I'm happy to re-run all of that once you've resolved these.

Also, it's not a showstopper, but it's best practice to handle context-menu items through a background script (entry point: background_url: as defined in the manifest.json, eg: https://github.com/owlbear-rodeo/colored-rings/blob/main/public/manifest.json), so that any right-click functionality does not depend on the Action popover being open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants