Skip to content

chore(deps-dev): Bump gulp-eslint from 3.0.1 to 6.0.0 - #781

Open
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/gulp-eslint-6.0.0
Open

chore(deps-dev): Bump gulp-eslint from 3.0.1 to 6.0.0#781
dependabot[bot] wants to merge 1 commit into
masterfrom
dependabot/npm_and_yarn/gulp-eslint-6.0.0

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 19, 2026

Copy link
Copy Markdown
Contributor

Bumps gulp-eslint from 3.0.1 to 6.0.0.

Release notes

Sourced from gulp-eslint's releases.

v6.0.0

  • Upgrade to ESLint 6 (#235) a35a203

adametry/gulp-eslint@v5.0.0...v6.0.0

Changelog

Sourced from gulp-eslint's changelog.

6.0.0

5.0.0

4.0.2

  • Update plugin-error to ^1.0.0

4.0.1

  • Make fix option work even if quiet option is also enabled
  • Remove deprecated gulp-util dependency and use individual modules instead

4.0.0

Commits

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 19, 2026
@dependabot
dependabot Bot requested a review from a team as a code owner July 19, 2026 22:03
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 19, 2026
@phil-davis

Copy link
Copy Markdown
Contributor

https://github.com/owncloud/contacts/actions/runs/29705455867/job/88241563264?pr=781

46:1  error  Expected indentation of 6 tabs but found make[2]: Leaving directory '/home/runner/work/contacts/contacts'

Lots of these kind of lint errors, and other "real" problems. Work will be needed to do this triple major version bump.

@DeepDiver1975

Copy link
Copy Markdown
Member

Holding: CI is failing (not a rebase conflict). Failing checks: build + Commits semantic + JS Unit. A rebase won't fix this — needs a human/upstream fix.

@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/gulp-eslint-6.0.0 branch from b39bc27 to e2f469e Compare July 20, 2026 13:43
@phil-davis

Copy link
Copy Markdown
Contributor

@dependabot rebase

@dependabot dependabot Bot changed the title Bump gulp-eslint from 3.0.1 to 6.0.0 chore(deps-dev): Bump gulp-eslint from 3.0.1 to 6.0.0 Jul 21, 2026
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/gulp-eslint-6.0.0 branch 2 times, most recently from 0244d13 to efd1416 Compare July 27, 2026 08:37
Bumps [gulp-eslint](https://github.com/adametry/gulp-eslint) from 3.0.1 to 6.0.0.
- [Release notes](https://github.com/adametry/gulp-eslint/releases)
- [Changelog](https://github.com/adametry/gulp-eslint/blob/master/CHANGELOG.md)
- [Commits](adametry/gulp-eslint@v3.0.1...v6.0.0)

---
updated-dependencies:
- dependency-name: gulp-eslint
  dependency-version: 6.0.0
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/gulp-eslint-6.0.0 branch from efd1416 to 800d664 Compare July 27, 2026 09:34
@DeepDiver1975

Copy link
Copy Markdown
Member

Holding: CI is failing (not a rebase conflict) — root-cause refinement, supersedes my earlier note on this PR.

This is not a gulp-3 problem: master already has gulp ^5.0.1 with gulp.series, so that hypothesis is disproven.

gulp-eslint bundles ESLint as a direct dependency — 3.0.1 depends on eslint ^3.0.0, 6.0.0 depends on eslint ^6.0.0 — so this bump is really an ESLint 3 -> ESLint 6 jump (the repo declares no eslint devDependency of its own). npm run build is gulp, whose default task is gulp.series("eslint", ...), which is why Build dist / build / Build goes red; and .eslintrc.json is still written against ESLint 3 (e.g. "quotes": ["error", "single", "avoid-escape"], the legacy string form of avoidEscape).

Current failing checks: Build dist / build / Build and CI / JS Unit / Javascript Unit. (My earlier note also listed "Commits semantic" — that one is no longer red.)

A rebase will not fix this — it needs an ESLint 6 config migration by a human.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants