Require all final breadcrumbs to not point to their parents - #3337
Merged
Conversation
Breadcrumbs breaking this rule fell into two cases: 1. Pointing to a parent view that defaulted back to "where you just came from". Not a big deal, but a little silly 2. Pointing to a parent view that then defaulted to _some other place._ That's weird!
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Author
|
Terrible commit name |
fakemonster
changed the title
| if (last === undefined) expect.fail(`Found no breadcrumbs for ${path}`) | ||
| expect(dropFinalSlash(path)).toEqual(dropFinalSlash(last.path)) | ||
| } | ||
| }) |
Collaborator
There was a problem hiding this comment.
love this kind of test
david-crespo
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Inspired by a comment on Charlie's webhooks PR. I was curious on whether there were terminal breadcrumbs that didn't abide by this reasoning, and inadvertently pointed to parent pages. And there were!
Breadcrumbs breaking this rule fell into two cases: