sidecar: use RDL-defined types in sequencer - #522
Merged
Conversation
nathanaelhuffman
approved these changes
Aug 20, 2026
nathanaelhuffman
left a comment
nathanaelhuffman
left a comment
Collaborator
There was a problem hiding this comment.
One tiny comment about whether None becomes overloaded or confusing once this is used in Rust, otherwise LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the state, step, and error types for the Tofino sequencer code out of RTL and into the RDL definition. There are no functional changes here, just shuffling types around. This will support allowing the Hubris sidecar-seq code to leverage the same types as the FPGA. Currently we duplicate the type definitions, once in the BSV and again in Rust.
Fixes #521