Skip to content

NY: Fix tests that could never fail - #616

Open
jubnzv wants to merge 3 commits into
paritytech:mainfrom
jubnzv:fix-necessist-findings
Open

jubnzv wants to merge 3 commits into
paritytech:mainfrom
jubnzv:fix-necessist-findings

Conversation

@jubnzv

@jubnzv jubnzv commented Sep 25, 2026

Copy link
Copy Markdown
  • test_copy_propagation: the assert was x || true, so it was always true.
  • test_constant_propagation_through_add: there was no assert at all.
  • condition_observes_overlap_store_flags_unbounded: one of its setup lines did nothing, so it tested less than it claimed.

Found using necessist.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant