Images update with VeloC - #29
Conversation
…updated action, not pdidev/.. action
…bility issue between doxygen and spdlog
… with shared mem support, include git in the temporary velocdl stage, remove use of pip to download tools needed to install veloc, install veloc in /opt/veloc
…libcurl4-openssl-dev in some distributions like jammy
jmorice91
left a comment
jmorice91
left a comment
There was a problem hiding this comment.
I request only change on the exclude comment.
A similar work is done for catalyst plugin because we need a minimal cmake version to add this plugin in the image.
| python3-bs4 \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
|
|
||
| WORKDIR /opt/src |
There was a problem hiding this comment.
@pdidev/pdi-maintainers Do you want to adopt the convention '/opt/src/' at the source file for third-party software?
There was a problem hiding this comment.
What is the current convention?
There was a problem hiding this comment.
There is no current convention as far as I know. For my point of view, It is a good idea to use '/opt/src' for that.
|
|
||
| COPY --from=velocdl /opt/veloc /opt/veloc | ||
|
|
||
| ENV CMAKE_PREFIX_PATH=/opt/veloc:${CMAKE_PREFIX_PATH} |
There was a problem hiding this comment.
What is the value of CMAKE_PREFIX_PATH before this line?
There was a problem hiding this comment.
I printed it and it is empty before this line
There was a problem hiding this comment.
Are you suggesting to set CMAKE_PREFIX_PATH instead of appending to it?
3 participants
No description provided.