Drop deprecated mapbox entries removed in plotly v7.0.0 - #162
Merged
Merged
Conversation
plotly 7.0.0 removed the mapbox layout key and the scattermapbox trace
type (replaced by map / scattermap since plotly 5.24). The template in
plotly_theme.py still registered both, so import ccp raised:
ValueError: Invalid property specified for object of type
plotly.graph_objs.layout.template.Data: 'scattermapbox'
ccp draws no maps, so the entries are simply deleted. Verified that
import ccp works on plotly 6.9.0 and 7.0.0 after this change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plotly 7.0.0 removed the
mapboxlayout key and thescattermapboxtrace type (replaced bymap/scattermapsince plotly 5.24). The ccp template inccp/plotly_theme.pystill registered both, so on plotly 7import ccpraised:This also broke
import ross, which imports ccp.ccp draws no maps, so the two entries are simply deleted, following the precedent of 3b19365 ("Drop deprecated heatmapgl traces in plotly v6.0.0"). No compatibility shim is added; the resulting template loads on plotly 5.x through 7.0.
Verification
import ccpworks on plotly 6.9.0 (current lock) and on plotly 7.0.0 in a throwaway venv.main, the same plotly 7 venv reproduces theValueErrorabove.uv run pytest -m "not slow" -n auto --dist loadfile→ 191 passed.