meson: enforce minimum GStreamer version 1.26 - #27
Merged
Merged
Conversation
* ret now starts as PEX_RTMP_SERVER_STATUS_OK; the genuine parse failure explicitly sets PEX_RTMP_SERVER_STATUS_PARSE_FAILED before goto done, and the loop bails out early if a message handler fails. * Added client_handle_flv_script_data() which decodes the onMetaData AMF payload of a MSG_NOTIFY FLV tag into client->metadata and sets new_metadata, so the updated framerate is actually propagated to subscribers via client_maybe_update_metadata() instead of being silently dropped (previously subscribers always got the hardcoded framerate = 30.0 from client_set_default_metadata).
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…but we have to verify it has be decoded correctly.
Co-authored-by: havardgraff <1926313+havardgraff@users.noreply.github.com>
Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
Contributor
This reverts commit 4b782ca. Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
…and loosing old values." This reverts commit b9b872b. Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
This reverts commit a7698d7. Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
…o integer type." This reverts commit 85d15e5. Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
…s NULL, but we have to verify it has be decoded correctly." This reverts commit 3eca8fb. Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
This reverts commit 0dc8e00. Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
This reverts commit ebd4cda. Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
This reverts commit 4c31621. Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
This reverts commit 1658499. Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
Co-authored-by: camilo-celis <4216631+camilo-celis@users.noreply.github.com>
Contributor
Author
Addressed in 85e3729: the branch tip now removes the inherited #26 changes so the net diff against |
camilo-celis
changed the base branch from
ga/critical_mode_drops_rtmp_connection
to
master
August 27, 2026 11:49
camilo-celis
changed the title
camilo-celis
marked this pull request as ready for review
August 27, 2026 11:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GstIdStr was introduced since: 1.26 so lets use that as our min. requirement.