feat: add admin FORCE_RELOAD command - #1502
Draft
jkaczman wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an admin
FORCE_RELOADcommand, which acts as a normalRELOADplus guarantees all in-flight transactions are terminated prior to the command's conclusion (and subsequent transactions are sent to the newPools).Internally, it uses
pg_terminate_backendto terminate all PIDs corresponding to active connections on eachPool.Includes some preventive measures to prevent cases like transactions slipping through to the old
Poolbetween termination and the reload; this is prevented by a temporary (not-propagated) pause flag set on thePoolbefore terminations occur.Couple TODOs marked in the code I will look into before I mark this ready to merge.
Fixes #1472.