ext/curl: show curl option name in error message

[Sjord]

Retrieve the option name by using curl_easy_option_by_id or by walking zend_constants, depending on whether the curl version used has curl_easy_option_by_id.

Showing the option name is especially useful when using curl_setopt_array. A user may specify many options, and this change makes it clear which option is wrong exactly.

Related to #10097, #22705.

[Sjord]

@GrahamCampbell What do you think about this fallback in case curl_easy_option_by_id is not available?

[Sjord]

php_curl_option_get_name currently does not work correctly for values that have multiple names:

• CURLOPT_FTP_RESPONSE_TIMEOUT = CURLOPT_SERVER_RESPONSE_TIMEOUT
• CURLOPT_ENCODING = CURLOPT_ACCEPT_ENCODING
• CURLOPT_MAIL_RCPT_ALLLOWFAILS = CURLOPT_MAIL_RCPT_ALLOWFAILS

I think this is currently OK and can probably be fixed in the future.

I am also wondering if it makes sense to loop through zend_constants as a fallback when curl_easy_option_by_id returns null, but I can't think of a situation where that would result in anything.

[GrahamCampbell]

Should this get a short Curl entry in NEWS? It changes user-visible validation messages, and the recent error-message clean-ups in other extensions have been recorded there. Perhaps:

- Curl:
  . Improved cURL option validation errors to include the option name.
    (Sjoerd Langkemper)

[Sjord]

@GrahamCampbell Thanks, great feedback.

[Sjord]

This is ready.

[Sjord]

@arnaud-lb Could you take a look at this, and perhaps merge it?

[arnaud-lb]

Looks good to me!

[arnaud-lb]

Thank you!