Skip to content

Replace deprecated CC_MD5 with CC_SHA256 for cache key generation #658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PullaguraSatish wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Replace deprecated CC_MD5 with CC_SHA256 for cache key generation #658

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions Source/Classes/PINRemoteImageManager.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1568,18 +1568,18 @@ - (NSString *)cacheKeyForURL:(NSURL *)url processorKey:(NSString *)processorKey
//In case the generated key exceeds PINRemoteImageManagerCacheKeyMaxLength characters,
//we return the hash of it instead.
if (cacheKey.length > PINRemoteImageManagerCacheKeyMaxLength) {
__block CC_MD5_CTX ctx;
CC_MD5_Init(&ctx);
__block CC_SHA256_CTX ctx;
CC_SHA256_Init(&ctx);
NSData *data = [cacheKey dataUsingEncoding:NSUTF8StringEncoding];
[data enumerateByteRangesUsingBlock:^(const void * _Nonnull bytes, NSRange byteRange, BOOL * _Nonnull stop) {
CC_MD5_Update(&ctx, bytes, (CC_LONG)byteRange.length);
CC_SHA256_Update(&ctx, bytes, (CC_LONG)byteRange.length);
}];

unsigned char digest[CC_MD5_DIGEST_LENGTH];
CC_MD5_Final(digest, &ctx);
unsigned char digest[CC_SHA256_DIGEST_LENGTH];
CC_SHA256_Final(digest, &ctx);

NSMutableString *hexString = [NSMutableString stringWithCapacity:(CC_MD5_DIGEST_LENGTH * 2)];
for (int i = 0; i < CC_MD5_DIGEST_LENGTH; i++) {
NSMutableString *hexString = [NSMutableString stringWithCapacity:(CC_SHA256_DIGEST_LENGTH * 2)];
for (int i = 0; i < CC_SHA256_DIGEST_LENGTH; i++) {
[hexString appendFormat:@"%02lx", (unsigned long)digest[i]];
}
cacheKey = [hexString copy];
Expand Down