Forward ref check - #136
Closed
cchantep wants to merge 2 commits into
Closed
Conversation
cchantep
force-pushed
the
fix/120_forward_ref_check
branch
2 times, most recently
from
January 27, 2018 14:43
40554be to
9575b0a
Compare
gmethvin
reviewed
Jan 30, 2018
cchantep
force-pushed
the
fix/120_forward_ref_check
branch
from
April 28, 2018 19:27
9575b0a to
1050dd5
Compare
richdougherty
suggested changes
May 7, 2018
cchantep
force-pushed
the
fix/120_forward_ref_check
branch
2 times, most recently
from
September 25, 2018 12:47
213db84 to
b0222b1
Compare
cchantep
commented
Sep 25, 2018
|
|
||
| def apply[A](read: JsValue => JsResult[A], write: A => JsObject): OFormat[A] = new OFormat[A] { | ||
| def apply[A](read: JsValue => JsResult[A], write: A => JsObject): OFormat[A] = | ||
| new FunctionalOFormat[A](read, write) |
Member
Author
There was a problem hiding this comment.
Use specific impl class, not to exclude null-check for instances created by these factories
| implicit val JsArrayReducer = Reducer[JsValue, JsArray](js => JsArray(Array(js))) | ||
| } | ||
|
|
||
| /** |
Member
|
is anyone interested in pursuing this further, or should we just close it for inactivity? |
cchantep
force-pushed
the
fix/120_forward_ref_check
branch
from
June 26, 2021 12:28
b0222b1 to
ab55f42
Compare
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
cchantep
marked this pull request as ready for review
June 26, 2021 12:29
cchantep
force-pushed
the
fix/120_forward_ref_check
branch
from
June 26, 2021 13:00
ab55f42 to
bc570f2
Compare
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
cchantep
force-pushed
the
fix/120_forward_ref_check
branch
from
June 26, 2021 13:06
bc570f2 to
02570d0
Compare
|
At least one pull request committer is not linked to a user. See https://help.github.com/en/articles/why-are-my-commits-linked-to-the-wrong-user#commits-are-not-linked-to-any-user |
SethTisue
marked this pull request as draft
June 26, 2021 15:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #120