Repository navigation
ci(modulus): run registry workflows with pnpm - #39
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Modulus’ GitHub Actions workflows to use pnpm (pinned to 11.5.1) instead of npm/npx so installs and tool execution work correctly in a pnpm workspace (notably with workspace:* dependencies).
Changes:
- Replaces
npm ci/npm installwithpnpm install --frozen-lockfileacross registry and gate workflows. - Replaces
npx <tool>invocations withpnpm exec <tool>for repo-local executables (e.g.,tsx,tsc). - Updates post-merge CI feedback workflow to run lint/typecheck/test via pnpm.
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| .github/workflows/plugin-gate.yml | Switch plugin gate and registry build check steps from npm/npx to pnpm install + pnpm exec |
| .github/workflows/native-extension-catalog.yml | Switch validation/promotion steps to pnpm install + pnpm run/exec |
| .github/workflows/host-effects-contract.yml | Switch host-effects contract gate to pnpm install + pnpm run |
| .github/workflows/ci-feedback-loop.yml | Switch post-merge lint/typecheck/test runner to pnpm |
| .github/workflows/build-registry.yml | Switch registry build workflow to pnpm install + pnpm exec |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+79
to
+83
| @@ -76,7 +80,7 @@ jobs: | |||
| run: | | |||
| if [ -d plugins/${{ matrix.plugin }}/tests ]; then | |||
| echo "Running plugin tests..." | |||
| npx vitest run plugins/${{ matrix.plugin }}/tests/ --passWithNoTests || echo "⚠️ Tests failed (non-blocking)" | |||
| pnpm exec vitest run plugins/${{ matrix.plugin }}/tests/ --passWithNoTests || echo "⚠️ Tests failed (non-blocking)" | |||
Co-authored-by: kayodebristol <3579196+kayodebristol@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the workflow installation failure exposed by the native catalog merge. Modulus is a pnpm workspace and npm cannot resolve its workspace:* dependency, so registry, plugin, host-effects, native-catalog, and post-merge workflows now use pnpm 11.5.1 with the frozen lockfile and local executables.\n\nValidation:\n- pnpm install --frozen-lockfile\n- pnpm run gate:host-effects\n- pnpm run gate:native-extension-catalog\n- pnpm run test:native-extension-catalog\n- pnpm run check\n- pnpm run lint\n- pnpm test\n- actionlint all workflow files