Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #342 +/- ##
==========================================
- Coverage 94.77% 94.75% -0.03%
==========================================
Files 97 97
Lines 3619 3623 +4
Branches 282 282
==========================================
+ Hits 3430 3433 +3
- Misses 188 189 +1
Partials 1 1
🚀 New features to boost your workflow:
|
BDoignies
force-pushed
the
Factory
branch
2 times, most recently
from
June 16, 2026 10:24
b5571c5 to
aec2756
Compare
Contributor
|
Wait for #343 . |
nmellado
reviewed
Jun 22, 2026
| // of the Basket... Instead we check that the function defines in it exists and | ||
| // return something that is coherent for derivatives to exists. | ||
| template <typename T> | ||
| concept ProvidesDerivatives = (T::isScaleDer() || T::isSpaceDer()) && (T::derDimension() > 0); |
Contributor
There was a problem hiding this comment.
Better be in Basket concepts as ProvidesSpaceDerivatives ?
BDoignies
force-pushed
the
Factory
branch
4 times, most recently
from
September 16, 2026 13:27
ccf109c to
ed6f6e5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed with @nmellado , here is a starter implementation of a factory within Ponca.