Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #348 +/- ##
=======================================
Coverage 94.77% 94.78%
=======================================
Files 97 97
Lines 3619 3621 +2
Branches 282 282
=======================================
+ Hits 3430 3432 +2
Misses 188 188
Partials 1 1
🚀 New features to boost your workflow:
|
But introduce code that need to be fixed prior merging
| static constexpr bool isDDValid = true; | ||
| }; // class GaussianWeightKernel | ||
|
|
||
| /*! |
There was a problem hiding this comment.
Given the description "this is not a weight kernel", this class should probably be in another file.
There was a problem hiding this comment.
Yeah, I hesitated a lot.
I wrote This is not a decreasing weight function, but it is actually a weight kernel in the end. But it is used to weight basis functions according to distance, not neighbors.
There was a problem hiding this comment.
I kept it here as has the same semantics: function and its derivatives.
| { | ||
|
|
||
| /*! | ||
| * \brief Corrected Normal Current Fit type. |
There was a problem hiding this comment.
Doc is copy pasted from CNC
There was a problem hiding this comment.
yes, WIP. Keep this open.
| return grad; | ||
| } | ||
|
|
||
| // |
There was a problem hiding this comment.
Should be removed (copy-pasted from cnc)
| * \tparam PointContainer An STL-like container storing the points | ||
| */ | ||
| template <typename IndexRange, typename PointContainer> | ||
| PONCA_MULTIARCH inline FIT_RESULT computeWithIds(const IndexRange& ids, const PointContainer& points) |
There was a problem hiding this comment.
Now that ponca supports C++20, I suggest instead something like:
auto view = ids | std::views::transform([&](size_t i) { return points[i]; });
compute(view.begin(), view.end());Performance wise this should be about the same. Transforms and pipes inherit the iterator category.
There was a problem hiding this comment.
Now that I wrote the comment, I wonder if this could be the default for ComputeObject::compute...
There was a problem hiding this comment.
yes, would be better :)
| using NeighborFilter = DistWeightFilter<DataPoint,ConstantWeightKernel<Scalar>>; | ||
|
|
||
| PONCA_FITTING_APIDOC_SETWFUNC | ||
| PONCA_MULTIARCH inline void setNeighborFilter(const NeighborFilter& ) { ; } |
There was a problem hiding this comment.
This kind of trick is annoying.
2 participants
No description provided.