[Feature] Resolve Container-log Override - #805
Merged
mergify[bot] merged 3 commits intoSep 8, 2026
Merged
Conversation
rquidute
approved these changes
Sep 4, 2026
|
Queued — the merge queue status continues in this comment ↓. |
Merge Queue Status
This pull request spent 22 seconds in the queue, including 2 seconds running CI. Required conditions to merge
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: project-chip/certification-tool#1091
Related to: project-chip/certification-tool-backend#366
Description
PayloadParsingTestBaseClass (onboarding QR/manual-pairing-code tests) owns its own SDKContainer, so it needs to resolve and pass
th_config.enable_container_logsthe same way PythonTestCase/ChipSuite do.Changed
onboarding_script_support.py: added_container_logs_enabled()(with a_safe_config()guard against .config being unavailable), passed through to the 5 sdk_container.start/send_command/destroy call sites.