Skip to content

chore: update motd + config - #1077

Draft
theMimolet wants to merge 1 commit into
projectbluefin:mainfrom
theMimolet:chore/update-motd
Draft

chore: update motd + config#1077
theMimolet wants to merge 1 commit into
projectbluefin:mainfrom
theMimolet:chore/update-motd

Conversation

@theMimolet

Copy link
Copy Markdown
Contributor

bluefin-common PR

What does this change?

Updates umotd + uwelcome + config

Why?

Adds a hotfix + ujust report in the config

PR pipeline

opened ──▶ 4-review ──▶ approved ──▶ merged

A maintainer reviews and approves; merge goes through the merge queue.
Select blocked or hold to pause the work.

Checklist

  • PR title follows Conventional Commits (fix:, feat:, docs:, ci:, refactor:, etc.)
  • just check passes
  • pre-commit run --all-files passes
  • Skill doc updated if the change affects agent-facing conventions or behavior (see docs/skills/skill-improvement.md)
  • AGENTS.md / docs/SKILL.md / docs/skills/ links remain valid
  • CI is green after push: gh run list --repo projectbluefin/common --limit 5

AI attribution

If this PR includes AI-authored commits, include both trailers:

Assisted-by: <Model> via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Note

Maybe look if we still have an issue where umotd is still the old version for users and maybe get rid of it and its config file / find another way to update it more reliably ?

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: PR #1077 (chore: update motd + config)

Findings

  1. Containerfile pinned commits:
    • Updates umotd commit pin to 97520c61e8fca7eae7359bf3d329542078f17412.
    • Updates uwelcome commit pin to d260ccbb56db820f78b0b2a18b07c1a213918ce1.
  2. Uwelcome config:
    • Adds ujust report with description cmd_report under system_files/shared/etc/uwelcome/config.json.
  3. Sanity Check:
    • JSON syntax in config.json is valid.
    • Containerfile build steps remain structurally sound with sha256 pinned base image.

Verdict

LGTM.

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The unit test suite is failing in tests/test_motd_integration.bats:

not ok 17 uwelcome config: command descriptions use known translation keys
# (in test file tests/test_motd_integration.bats, line 185)
#   `[ "${status}" -eq 0 ]' failed

"cmd_report" is not in the recognized list of translation keys (["cmd_list","cli_pkg","term_bling","banner_toggle","sys_info","man_upd"]). Either tests/test_motd_integration.bats needs to be updated if uwelcome upstream added cmd_report, or a valid key should be used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants