chore: update motd + config - #1077
Draft
theMimolet wants to merge 1 commit into
Draft
Conversation
castrojo
reviewed
Sep 10, 2026
castrojo
left a comment
Contributor
There was a problem hiding this comment.
Review: PR #1077 (chore: update motd + config)
Findings
- Containerfile pinned commits:
- Updates
umotdcommit pin to97520c61e8fca7eae7359bf3d329542078f17412. - Updates
uwelcomecommit pin tod260ccbb56db820f78b0b2a18b07c1a213918ce1.
- Updates
- Uwelcome config:
- Adds
ujust reportwith descriptioncmd_reportundersystem_files/shared/etc/uwelcome/config.json.
- Adds
- Sanity Check:
- JSON syntax in
config.jsonis valid. - Containerfile build steps remain structurally sound with sha256 pinned base image.
- JSON syntax in
Verdict
LGTM.
castrojo
requested changes
Sep 10, 2026
castrojo
left a comment
Contributor
There was a problem hiding this comment.
The unit test suite is failing in tests/test_motd_integration.bats:
not ok 17 uwelcome config: command descriptions use known translation keys
# (in test file tests/test_motd_integration.bats, line 185)
# `[ "${status}" -eq 0 ]' failed
"cmd_report" is not in the recognized list of translation keys (["cmd_list","cli_pkg","term_bling","banner_toggle","sys_info","man_upd"]). Either tests/test_motd_integration.bats needs to be updated if uwelcome upstream added cmd_report, or a valid key should be used.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bluefin-common PR
What does this change?
Updates umotd + uwelcome + config
Why?
Adds a hotfix + ujust report in the config
PR pipeline
Checklist
fix:,feat:,docs:,ci:,refactor:, etc.)just checkpassespre-commit run --all-filespassesdocs/skills/skill-improvement.md)AGENTS.md/docs/SKILL.md/docs/skills/links remain validgh run list --repo projectbluefin/common --limit 5AI attribution
If this PR includes AI-authored commits, include both trailers:
Note
Maybe look if we still have an issue where umotd is still the old version for users and maybe get rid of it and its config file / find another way to update it more reliably ?