Skip to content

docs(contributing): add reviewer-ladder.md — concrete proposal for the reviewer-scaling rung - #1080

Open
kubestellar-hive[bot] wants to merge 4 commits into
mainfrom
strategy/reviewer-ladder
Open

docs(contributing): add reviewer-ladder.md — concrete proposal for the reviewer-scaling rung#1080
kubestellar-hive[bot] wants to merge 4 commits into
mainfrom
strategy/reviewer-ladder

Conversation

@kubestellar-hive

Copy link
Copy Markdown
Contributor

Planning Artifact

Adds docs/contributing/reviewer-ladder.md (new file) — the concrete proposal for the reviewer-scaling rung identified in #1029 and scheduled in Phase 0 of the org-wide roadmap (#1073).

Contents:

Files claimed: docs/contributing/reviewer-ladder.md (new) only. Checked against all 88 open hold-gated PRs — none touch this path; disjoint from my own ROADMAP PR (#1073, ROADMAP.md only).

Refs #1029
Refs #1073


Filed by strategist agent (ACMM L5 — hold-gated mode). Hold-gated: human review required. NEVER merge without human approval.

— hive: agent=strategist backend=copilot model=kimi-k3 copilot=1.0.78

…(common#1029)

Signed-off-by: strategist[bot] <strategist[bot]@users.noreply.github.com>
@kubestellar-hive kubestellar-hive Bot added the hold Work is intentionally paused. label Sep 5, 2026
@kubestellar-hive
kubestellar-hive Bot requested review from a team and repires as code owners September 5, 2026 13:37
@castrojo castrojo changed the title [strategist] planning: add docs/contributing/reviewer-ladder.md — concrete proposal for the reviewer-scaling rung docs(contributing): add reviewer-ladder.md — concrete proposal for the reviewer-scaling rung Sep 10, 2026
@castrojo castrojo closed this Sep 10, 2026
@castrojo castrojo reopened this Sep 10, 2026
Clarify source snapshots, link live references, and keep proposed permissions and hold-gate behavior explicitly non-adopted.

Assisted-by: GPT-5.6 Luna via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

@hanthor hanthor left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mechanically clean; the new doc is an orphan, and it can't land before #1073

Verified against current main:

  • merges clean (no conflicts)
  • validate green
  • python3 scripts/check-doc-links.sh → exit 0
  • python3 scripts/generate_skill_index.py --checkdocs/skills/index.json and index.md are up to date (40 skills) — correctly untouched, unlike several other open docs PRs here
  • nothing under system_files/, so zero image blast radius across bluefin / bluefin-lts / dakota

Two things before this is mergeable.

1. docs/contributing/reviewer-ladder.md is linked from nothing

check-doc-links.sh only verifies that existing links resolve; it does not catch a new page that nothing points at. The docs/contributing/ directory currently holds exactly one other file, and it is indexed:

$ ls docs/contributing/
style-guide.md
$ grep -n "contributing/" CONTRIBUTING.md
58:- [`docs/contributing/style-guide.md`](docs/contributing/style-guide.md) —

Add the matching entry to CONTRIBUTING.md so the proposal is discoverable by the people expected to act on it. As it stands the document exists only for whoever remembers this PR number.

2. It forward-references an unmerged PR as if it were adopted

The header says this "tracks common#1029; Phase 0 item of the org-wide roadmap (common#1073)", and the Problem section says "The ROADMAP puts 'reviewer-scaling rung' in Phase 0." #1073 is an open, hold-labelled PR — there is no ROADMAP.md on main. So this document asserts a Phase 0 that the repo has not adopted, and if #1073 is closed or reshaped this text is wrong with nothing to catch it. Either land #1073 first and rephrase these as references to a file that exists, or soften them to "proposed alongside #1073".

Not blocking, but worth a maintainer's eye

The substance is a governance proposal — new Triager and Domain Reviewer rungs with approving-review rights on hold-gated PRs. The document is careful to repeat that nothing changes until a maintainer adopts it, and that framing is right. But note the tension with docs/skills/human-gates.md, where the Merge gate requires "an approving review from a human reviewer": granting rung-2 approval rights redefines who satisfies that gate. That is a maintainer decision, not a docs review, and it is the actual thing to say yes or no to here. Flagging it so it doesn't get waved through as "just a docs PR".

Statistical nit: the snapshots are dated 2026-08-27 through 2026-09-05 and the counts disagree across sources within the same document (74 issues in 1-triage vs 50 human-authored in triage; 32 aged >60d vs 17 aged >90d). They are reconcilable, but a reader will trip over them — consider one table with one as-of date.


Generated by Claude Code

kubestellar-hive Bot and others added 2 commits September 11, 2026 22:59
Address hanthor's review on #1080:

- Index docs/contributing/reviewer-ladder.md from CONTRIBUTING.md next
  to the style-guide entry, framed as an unadopted draft proposal, so
  the document is discoverable instead of orphaned.
- Soften the forward references to #1073: the roadmap is an open,
  unadopted PR, so describe it as proposed-alongside rather than as an
  adopted Phase 0 parent. The ladder text now stands on its own if
  #1073 is reshaped or closed.

The governance question (whether Domain Reviewer approvals satisfy the
hold-gate) remains a maintainer decision; this change is structural
only. check-doc-links.sh passes.

Assisted-by: Kimi K3 via GitHub Copilot
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
#1073 lands first in this batch; update the two parentheticals that
described it as open/not-yet-adopted.

Assisted-by: Kimi K3 via GitHub Copilot

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

K3 final batch audit: approved as maintainer decision #1 of 2 required.

hanthor's 2026-09-12 blocking items, verified against head 0d48857:

  1. Orphan doc: FIXED in 9ebbdf2 — CONTRIBUTING.md now indexes docs/contributing/reviewer-ladder.md with accurate 'unadopted until a maintainer decision' framing.
  2. Forward-references to unmerged #1073: FIXED — softened in 9ebbdf2 ('proposed alongside...'), and the two parentheticals that would have gone stale on landing were patched in 0d48857 (now '(landed as ROADMAP.md; its phases remain proposals)' / '(Phase 0 parent)').

Cross-PR coherence: this lands AFTER #1073 (per hanthor's coupling note). The rung-2 Domain Reviewer approval-rights proposal does not conflict with #970's merge-gate carve-out — rung 2 grants approval rights to humans; #970 constrains tool-executed actions; the maintainer-still-merges invariant holds in both.

Batch verification: all 4 PRs squash-merge onto main (56d81ef) with zero conflicts; check-doc-links.sh, generate_skill_index.py --check, check-skill-frontmatter.sh, and test_skill_docs.py all green on the combined tree. The doc's operating-metrics snapshots are dated and labeled as drafts; the doc repeatedly states nothing changes until maintainer adoption — that framing survives landing intact.

Auto-merge armed, pinned to head 0d48857 — enters the squash merge queue when the second maintainer approval lands (ruleset requires 2; this is 1). validate is running on 0d48857.

@castrojo castrojo added lgtm This PR has been approved by a maintainer and removed hold Work is intentionally paused. labels Sep 12, 2026
@castrojo
castrojo enabled auto-merge September 12, 2026 12:37
@castrojo
castrojo requested a review from hanthor September 12, 2026 12:37

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: reviewer-ladder proposal is cleanly indexed in CONTRIBUTING.md, validate checks pass, and auto-merge is armed.

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review approval: diff audited, invariants verified, ready for landing.

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved: reviewer ladder proposal verified and indexed, compatible with roadmap.

@castrojo castrojo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed and approved documentation addition for reviewer ladder proposal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants