fix(brew): use valid brew tap trust commands - #978
Open
kubestellar-hive[bot] wants to merge 2 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: kubestellar-hive[bot] <kubestellar-hive[bot]@users.noreply.github.com>
kubestellar-hive
Bot
requested review from
a team,
ahmedadan,
castrojo,
hanthor,
inffy,
ledif and
repires
as code owners
August 9, 2026 04:42
This was referenced Aug 28, 2026
Merged
hanthor
requested changes
Sep 2, 2026
hanthor
left a comment
hanthor
left a comment
Member
There was a problem hiding this comment.
mergeable_state is dirty — this PR currently has a real merge conflict against main and needs a rebase before it can land. Separately, CI has not actually re-validated the current diff: only a single stale validate job ran (from before the repo split CI into test/build/validate jobs), so no unit test or build job has run against this code at all. Content itself (brew tap→trust split across system.just, apps.just, bazaar-hook, and skill docs) looks correct and consistent with Homebrew 6.0's requirements everywhere it touches — worth noting for the maintainer that sibling PR #1011 (also in this review pass) reintroduces the exact brew tap --trust bug this PR fixes, in the separate hooks.py file this PR doesn't touch.
Generated by Claude Code
castrojo
changed the title
pull Bot
pushed a commit
to joshyorko/common
that referenced
this pull request
Sep 10, 2026
…boot-key, toggle-user-motd, check-local-overrides, check-idle-power-draw, benchmark (projectbluefin#1048) ## Test Improvement Adds `tests/test_default_just.bats` — 23 BATS tests for `system_files/shared/usr/share/ublue-os/just/default.just`. Before this PR, exactly one of the file's 12 recipes was under test (`clean-system`, via `tests/test_clean_system_podman_path.bats`). The rest had zero coverage, including a firmware reboot and a Secure Boot MOK enrollment. ### Recipes claimed by this PR | Recipe | What is covered | |---|---| | `bios` | legacy-BIOS guard exits 1 and never reboots; EFI + confirm issues `systemctl reboot --firmware-setup`; declined confirmation does not reboot | | `bios-info` | all four `dmidecode -s` fields read under `sudo bash`; every field is labelled | | `enroll-secure-boot-key` | `mokutil --timeout -1` precedes the import; `akmods-ublue.der` is the imported cert; enrollment password guidance is printed | | `toggle-user-motd` | shim body is exactly `uwelcome toggle` | | `check-local-overrides` | only-in-`/etc` reporting; content divergence reporting; silence when trees match; `NO_COLOR=1` palette suppression; palette applied when unset; identity/credential `--exclude` set | | `check-idle-power-draw` | missing-`powerstat` guard exits 1 without invoking it; present path runs `powerstat -a -r` | | `benchmark` | `stress-ng` present runs the 1m matrix load without touching brew; accept path runs `brew install`/`brew link` then the load; decline path exits 0 with no install | ### Method Each shebang recipe body is extracted verbatim from `default.just` and executed against stubbed `gum`, `sudo`, `systemctl`, `dmidecode`, `mokutil`, `powerstat`, `stress-ng`, `brew`, and `uwelcome`. `/sys/firmware/efi` and the `/usr/etc /etc` diff operands are redirected into a sandbox with `sed`, so real control flow is exercised instead of grepped. `sudo` execs its argv so the `sudo bash <<EOF` heredocs run against the same stubs. ### Incidental finding pinned, not fixed `check-local-overrides` hardcodes `diff --color="always"`. `NO_COLOR=1` therefore suppresses only the palette the recipe applies itself with `sed`; `diff`'s own ANSI escapes still reach the terminal. One test documents that current behaviour so a future fix is visible. No production code is changed by this PR. ### Disjointness Explicitly claims only the seven recipes listed above in `default.just`, plus the new test file. - `device-info` (`default.just`) — **left to PR projectbluefin#1003**, not touched or asserted on. - `clean-system` (`default.just`) — already owned by `tests/test_clean_system_podman_path.bats`. - `shared.just` — left to PR projectbluefin#1034. - `system.just` — left to PR projectbluefin#1031. - `apps.just` — left to PRs projectbluefin#978, projectbluefin#1007, projectbluefin#1018. - `changelog.just` / `ublue-image-repo` — left to PR projectbluefin#1045. `Justfile`: one line, `bats tests/test_default_just.bats`, inserted immediately after the existing `test_clean_system_podman_path.bats` line rather than appended to the end of the recipe, specifically so it does not collide with PR projectbluefin#1031's append at the tail of the same recipe. `.github/workflows/unit-tests.yml` is intentionally **not** modified — the hive App token lacks the `workflows` permission, and that wiring gap is tracked separately by common#968. ### Verification ``` $ bats tests/test_default_just.bats 1..23 ok 1 .. ok 23 ``` ## Related Issue Refs projectbluefin#968 (the workflow-wiring half of the gap remains open). --- *Filed by quality agent (hold-gated mode). Human review required.* — hive: agent=quality backend=copilot model=claude-opus-5 Signed-off-by: quality <sec-check[bot]@users.noreply.github.com> Co-authored-by: quality <sec-check[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
pull Bot
pushed a commit
to joshyorko/common
that referenced
this pull request
Sep 10, 2026
…all-system-flatpaks (projectbluefin#1031) ## Cluster claimed **File under test:** `system_files/bluefin/usr/share/ublue-os/just/system.just` **Recipes:** `toggle-testing`, `toggle-vms`, `install-system-flatpaks` **Files changed:** `tests/test_system_just.bats` (new), `Justfile` (one line) No other file is touched. In particular this PR does **not** modify `.github/workflows/unit-tests.yml` — see *Known follow-up* below. ## Why `system.just` is 388 lines and the largest file in the repo with zero test coverage. `toggle-testing` builds the image ref passed to `bootc switch --enforce-container-sigpolicy`; a wrong channel mapping moves a user's machine to the wrong image, and today nothing catches that. ## What `tests/test_system_just.bats` extracts each recipe body from the justfile into a standalone script and runs it against mocked `jq`, `gum`, `pkexec`, `bootc`, `flatpak`, `brew` and `just`. Nothing on the host is read or written. 24 tests: | Recipe | Tests | Covers | |---|---|---| | `toggle-testing` | 14 | stable/latest → testing; lts → lts-testing; lts-hwe → lts-hwe-testing; testing → stable; lts-testing → lts; lts-hwe-testing → lts-hwe; unknown channel exits 1 with no switch; transport-prefix stripping (`ostree-image-signed:docker://`, `ostree-unverified-registry:`, bare ref); both declined prompts are no-ops; switch goes through `pkexec` | | `toggle-vms` | 6 | install when absent / remove when present; QEMU extension included in removal; only the session `uri_default` line stripped from `libvirt.conf`; declined prompts are no-ops | | `install-system-flatpaks` | 4 | `confirm=0` skips the prompt, `confirm=1` requires it; declining installs nothing; `TARGET_FLATPAK_FILE` override honoured | The `lts-testing → lts` and `lts-hwe-testing → lts-hwe` cases specifically pin the `${IMAGE_TAG/-testing/}` branch, which must not collapse the LTS channels down to `stable`. ## Verification ``` $ bats tests/test_system_just.bats 1..24 ok 1 .. ok 24 ``` Mutation-checked: flipping the `lts-hwe` mapping to `testing` fails the suite, so the tests bite rather than merely execute. ## Known follow-up — CI wiring The new file is wired into `just test`, but **not** into `.github/workflows/unit-tests.yml`: the hive App token lacks the `workflows` permission and GitHub rejects the push. A maintainer adding this one step makes it run in CI: ```yaml - name: Run bats (system.just) run: bats tests/test_system_just.bats ``` Same blocker applies to projectbluefin#968 (9 test files already in `tests/` and in `just test` that `unit-tests.yml` never runs — all 95 of those tests were confirmed passing locally while investigating this). ## Overlap check Compared against every open PR in the snapshot. Nearest neighbours: - **projectbluefin#961** (`[sec-check]` permissions block) and **projectbluefin#969**/projectbluefin#978/projectbluefin#980/projectbluefin#932 — none touch `system.just`, `tests/` or the `Justfile`. projectbluefin#961 edits `unit-tests.yml`, which this PR deliberately leaves alone, so there is no conflict. - No open PR in any authorized repo tests `system.just` recipes. Disjoint. --- *Filed by the quality agent (hold-gated mode). Human review required — do not merge on my account.* — hive: agent=quality backend=copilot model=claude-opus-5 Signed-off-by: kubestellar-hive[bot] <kubestellar-hive[bot]@users.noreply.github.com> Co-authored-by: kubestellar-hive[bot] <kubestellar-hive[bot]@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: castrojo <castrojo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Replace invalid
brew tap --trustinvocations with Homebrew 6.0-compatiblebrew tapfollowed bybrew trustacross ujust recipes and Bazaar hooks. Update brew lifecycle guidance so future recipes use the valid syntax.Fixes #814
Filed by scanner agent (ACMM L5 — hold-gated mode). Hold-gated: human review required.
— hive: agent=scanner backend=copilot model=gpt-5.6-luna copilot=1.0.59