fix(countme): count every published image variant under its family - #1250
Open
castrojo wants to merge 1 commit into
Open
fix(countme): count every published image variant under its family#1250castrojo wants to merge 1 commit into
castrojo wants to merge 1 commit into
Conversation
Clients send the published image name, so the id on the wire is `bluefin-lts-hwe-nvidia`, not `bluefin-lts`. The aggregation matched bare family ids and filtered on them in SQL, so every hardware and driver build was discarded before the counting rules ever saw it. - `normalizeCountmeRepo` strips `-nvidia` and `-hwe` and folds the result into its family, longest family first so an LTS image is never counted as flagship. - The SQL repo filter is gone; it pre-filtered to bare ids and dropped the variants before normalization could fold them. - Game mode stays an attribute, not an image. Removes adr/.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bug
Clients send the published image name. The aggregation matched bare family ids and filtered on them in SQL, so these were all discarded before the counting rules saw them:
Every one is a real published image.
The fix
normalizeCountmeRepostrips-nvidiaand-hwe, then folds into the family. Longest family first, so an LTS image is never counted as flagship.repo IN (...)SQL filter — it pre-filtered to bare ids and dropped variants before normalization could fold them.What this does and does not change
It does not move today's numbers. D1 currently holds only five distinct repo values (
bluefin,bluefin-lts,dakota,dakota-gaming,eos) — no variant has ever reached the service. The fix means they count correctly when they do.Ingest itself is verified working: a probe sent to
/metalinklanded intelemetry_eventsand was removed again.Verification
100c8cb8-f7df-46f8-9dff-0af607a2637e.2 + 40 + 11 = 53); an nvidia flagship build stays flagship;eosandfedorastill return null; folding is idempotent.just check: 0 lint errors, 1050/1050 tests pass.npm run build:cisucceeds.Also removes
adr/.