chore(deps): update projectbluefin/actions digest to 8895d09 - #361
mergeraptor[bot] wants to merge 1 commit into
Conversation
castrojo
left a comment
There was a problem hiding this comment.
Approved via Bluefin review: update projectbluefin/actions digest to 5fc955e.
0f5103e to
3cf8854
Compare
3cf8854 to
53843ef
Compare
36a155f to
d8da295
Compare
d8da295 to
b61c07d
Compare
b61c07d to
4135cff
Compare
4135cff to
3a04e65
Compare
hanthor
left a comment
There was a problem hiding this comment.
2564c7b..4d3b97e is a wide range — 40+ commits, ~4,350 changed lines in projectbluefin/actions — so I checked what actually reaches finpilot rather than taking the digest on faith. Of the twelve things the five workflows here pin, only four changed at all, and every one of them is inert under finpilot's current configuration.
| pinned path | changed in range? | reaches finpilot? |
|---|---|---|
bootc-build/preflight |
no | — |
bootc-build/dnf-cache |
no | — |
bootc-build/detect-changes |
no | — |
bootc-build/generate-tags |
no | — |
bootc-build/push-image |
no | — |
bootc-build/ghcr-cleanup |
no | — |
reusable-sync-branches.yml |
no | — |
bootc-build/setup-runner |
1 line | yes, harmless |
bootc-build/validate-pr |
5 lines | yes, a fix |
bootc-build/sign-and-publish |
15 lines | no — generate-sbom: false |
bootc-build/chunka |
14 lines | no — ENABLE_RECHUNKING: "false" |
reusable-promote-squash.yml |
83 lines | no — run_e2e: false |
The two that do land:
setup-runnerbumpstaiki-e/install-action1938d65→3a2284f, still SHA-pinned.validate-prreplaces a# shellcheck disable=SC2086word-split loop withread -ra+compgen -G, which fixes shellcheck globs containing spaces.pr-validation.ymlpassesshellcheck-glob: "build/*.sh"— no spaces — so this is a latent-bug fix, not a behaviour change here.
And the three that are gated off are worth naming explicitly, because they are the reason this is a safe bump today and would not be if any of those three flags flipped:
reusable-promote-squash.ymlnow replaces "find a completedpost-testing-e2eActions run matchinghead_sha" with "read ane2e/post-testingcommit status on the source commit, and only trust it if the poster is GitHub Actions itself."promote-main-to-stable.ymlsetsrun_e2e: falsewith the documented rationale in #281, so the new gate short-circuits atRUN_E2E != 'true'. When #281 is fixed andrun_e2eflips to true, finpilot will need a producer workflow that publishes that commit status — the old "just find a successful run" behaviour will no longer be there to fall back on.sign-and-publishsetsSYFT_RELATIONSHIPS_PACKAGE_FILE_OWNERSHIP: "false"and skips the GitHub attestation (with a::warning::, job still green) when the SBOM exceeds 16 MB. Inert here becausegenerate-sbom: false.chunka— see below.
One thing to carry elsewhere, not a blocker here. The chunka change (4f64578, moving the chunkah config from an env var to a mounted file to avoid E2BIG) looks wrong in its BuildStream branch. In the buildah branch the flag is correctly passed to chunkah:
--build-arg "CHUNKAH_ARGS=--config /run/src/config.json --max-layers ..."
but in the BST branch it lands among the podman run options, before the image reference:
sudo podman run --rm \
-v "${CHUNKAH_CONFIG_FILE}:/chunkah-config.json:ro" \
--config /chunkah-config.json \
"${CHUNKAH_REF}" build \
--max-layers "${MAX_LAYERS}" ...
--config is not a podman run option; it is a root-level persistent flag podman keeps for Docker compatibility and ignores. So either podman rejects the flag and the step fails, or — more likely, since cobra lets persistent flags be given at subcommand level — it is silently swallowed and chunkah never receives the config at all, losing the OCI labels (containers.bootc=1 among them) that the file was created to preserve. I could not run podman here to settle which, so treat that as "one of two bad outcomes" rather than a confirmed error message.
finpilot is not exposed (ENABLE_RECHUNKING: "false", and no xattr-manifest input, so it would take the buildah branch anyway). The repos that pass xattr-manifest — the BuildStream images — are the ones to check before they take this digest.
mergeable_state: blocked (two-approval ruleset), so this still needs a second reviewer. Renovate has automerge disabled on this one by config, so it wants a manual merge.
Generated by Claude Code
|
Narrowing my own note above so it doesn't send anyone hunting: I went and checked, and no repo in the org currently passes So the Doesn't change the verdict on this PR. Generated by Claude Code |
3a04e65 to
67e4399
Compare
67e4399 to
b2a3f22
Compare
This PR contains the following updates:
2564c7b→8895d092564c7b→8895d09Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR has been generated by Mend Renovate CLI.