Conversation
The unit-tests.yml paths filter missed four surfaces the BATS suite guards: custom/ujust recipes, .github/actions/check-token-health, .pre-commit-config.yaml and .shellcheck-scope. A change touching only those files merged without ever running the tests written to protect them. Extend both pull_request and push paths lists to cover every surface under test. Assisted-by: DeepSeek DeepSeek-V4 via Goose Signed-off-by: mendezr <mendezr@users.noreply.github.com>
![kubestellar-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #375
What
Extends the
pathsfilters on both thepull_requestandpushtriggers in
.github/workflows/unit-tests.ymlso the BATS suite runswhenever any surface it tests changes.
Why
The filter previously omitted four surfaces that
tests/unit/guards:.github/actions/check-token-health/check_token_health.shcheck-token-health_test.batscustom/ujust/custom-apps.justcustom-apps-just_test.batscustom/ujust/custom-system.justcustom-system-just_test.bats.pre-commit-config.yamlprecommit-brewfile-hook_test.bats.shellcheck-scopeshellcheck-scope_test.batsA change touching only those files merged without running the 69 tests
written to guard them. This extends both
paths:lists by:custom/**.shellcheck-scope.pre-commit-config.yaml.github/actions/**Nothing else changes — permissions, concurrency and the
batsjob areuntouched.
— hive: backend=goose model=deepseek/deepseek-v4-flash-0731