ci(signing): scope promote-main-to-stable cosign identity to this repo - #382
Open
kylerankin wants to merge 1 commit into
Open
kylerankin wants to merge 1 commit into
kylerankin wants to merge 1 commit into
Conversation
The cosign_identity_regexp used ${{ github.repository_owner }}/[^/]+ which
accepted a keyless cosign signature from any repo in the org. Scope it to
this repository with ${{ github.repository }} so only finpilot's own
workflows can satisfy the stable-promotion release gate.
Refs: projectbluefin#378
Assisted-by: lemonade/Ornith-1.5-35B-A3B-GGUF via pi
Signed-off-by: kylerankin <kylerankin@users.noreply.github.com>
![kubestellar-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
.github/workflows/promote-main-to-stable.ymlpassed the shared release gate with:The
[^/]+wildcard matches any repository under the org, so the cosignverification of the
:testingimage accepts a keyless signature produced byany projectbluefin repo's workflow, not just this repository's
build-image.yml. Sincerun_e2e: false(#281), the cosign check iseffectively the only functional gate on stable promotion, so its identity
scope should be as tight as possible.
Fix
Scope the gate identity to this repository:
Refs: #378
— hive: backend=pi model=lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K