ci(workflow): drop paths filter from unit-tests workflow - #386
Open
mrbobbytables wants to merge 1 commit into
Open
mrbobbytables wants to merge 1 commit into
mrbobbytables wants to merge 1 commit into
Conversation
Drop the paths filter from pull_request and push triggers in .github/workflows/unit-tests.yml so the unit test suite runs on all PRs and pushes. Tests in tests/unit cover subjects outside build/**, tests/**, and Justfile (such as .github/actions/**, .github/workflows/*.yml, custom/ujust/*.just, custom/brew/, and .pre-commit-config.yaml). Because the unit test suite runs in under a minute, running it across all changes prevents test drift and ensures all gated subjects are verified. Closes projectbluefin#384 Assisted-by: Gemini 3.8 Flash via GitHub Copilot CLI Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
![kubestellar-hive[bot]](https://avatars.githubusercontent.com/in/3568013?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #384
Summary
Drop the
paths:filter from thepull_requestandpushtriggers in.github/workflows/unit-tests.yml.Rationale
The
tests/unit/BATS suite asserts against subjects across several directories outside the previous filter:.github/actions/check-token-health/check_token_health.sh.github/workflows/pr-validation.ymland.github/workflows/renovate.yml(viatests/unit/shellcheck-scope_test.bats)custom/ujust/*.justcustom/brew/andcustom/flatpaks/fixtures.pre-commit-config.yamlChanges touching these subjects previously bypassed the unit tests on PRs and pushes to main/stable. Because the suite is lightweight and fast (~45 seconds) and serves as the repository's sole unit gate, running it on all changes avoids trigger drift whenever tests or subjects are added or modified.
Verification
bats tests/unitpassed all 196 tests cleanly.— hive: backend=copilot model=gemini-3.8-flash
🐝 Hive Agent:
contributor| SHA:13c0d1e