ci(lima): fix Lima template schema errors in CI workflow - #113
mrbobbytables wants to merge 2 commits into
Conversation
Add a GitHub Actions job that verifies the full installer chain inside a nested-virt Lima VM on a macOS runner, since the runner has no native KVM: Source elements -> Installer Raw Image -> systemd-sysinstall auto-partitioning & DDI copy (Lima VM) -> Installed target disk boot (Lima VM) -> multi-user.target / login prompt - .github/workflows/lima-e2e.yml: macOS job that installs Lima + QEMU, starts a nested-virt VM, and runs the verification there. Read-only token (PR code). - .github/scripts/lima-e2e-install-boot.sh: validate + build/export the installer, boot it unattended (systemd-sysinstall auto-partition + DDI copy), then boot the installed target and verify it reaches multi-user.target. - .github/scripts/bluefin-lima-template.yaml: Lima template with nested: enabled to expose /dev/kvm to the guest. Signed-off-by: kylerankin <kylerankin@users.noreply.github.com> Assisted-by: lemonade/Ornith-1.5-35B-A3B-GGUF-Q6_K via GitHub Copilot Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: kylerankin <kylerankin@users.noreply.github.com>
Update the Lima template schema to resolve limactl validate errors: - Extend base with template:_images/ubuntu-24.04 - Use nestedVirtualization: true instead of legacy nested: enabled - Remove unknown localShell field under ssh - Clean up containerd configuration to standard schema (system/user: false) - Add limactl validate step in CI workflow before VM creation - Add unit test coverage in tests/unit/test_lima_template.py Fixes projectbluefin#111 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
castrojo
left a comment
castrojo
left a comment
There was a problem hiding this comment.
LGTM. Verified template schema and unit tests cleanly pass.
|
This is a strict subset of #119, which carries both of these commits ( Merging both into Suggest closing this in favour of #119 and reviewing there — I've left a review on it. If the schema fix needs to land ahead of the nested-virt change, the cleaner shape is to rebase #119 onto this one rather than carrying two branches with duplicated commits. Checked locally on this branch: Generated by Claude Code |
Closing in favor of #149. Lima remains a local-development path; CI now reuses the exported build artifacts through |
4 participants
Resolves #111
Supersedes #104 (and resolves #101)
Summary
Fixes the Lima template configuration in
.github/scripts/bluefin-lima-template.yamlto addresslimactl validateschema errors reported in #111:base: [template:_images/ubuntu-24.04]to supply standard Ubuntu 24.04 image definitions and unit defaults.nestedVirtualization: trueinstead of the invalidnested: enabledkey.localShellfield underssh.containerdconfig to standard schema (system: false,user: false).limactl validatestep in.github/workflows/lima-e2e.ymlbefore VM creation.tests/unit/test_lima_template.pyto verify schema compliance and validate withlimactlwhen available.— hive: backend=copilot model=gemini-3.8-flash
🐝 Hive Agent:
contributor| SHA:c8aec0c